Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1369469

Re: [PATCH 1/3] staging: fwserial: (coding style) Turning every "unsigned" into "unsigned int"

Show all headers | View raw

On 03/29/2016 10:14 AM, Dominique van den Broeck wrote:
> Coding-style-only modifications to remove every warning saying:
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> 
> Compiled against revision "next-20160327".
> 
> (checkpatch.pl was updated to treat "UNSPECIFIED_INT" warnings
>  as of commit a1ce18e4f941d20 )

Please change $subject to "staging: fwserial: Convert unsigned to unsigned int"
With that,

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>


PS - For v2 of this patch, be sure to change the subject prefix to [PATCH v2 ...],
and note any changes in the diffstat area of the patch itself; eg.,


Signed-off-by: Dominique van den Broeck <domdevlin@free.fr>
---

v2: change subject per Peter Hurley's comments


 drivers/staging/fwserial/dma_fifo.c |  8 +++----
 drivers/staging/fwserial/dma_fifo.h | 16 +++++++-------
 drivers/staging/fwserial/fwserial.c | 38 +++++++++++++++++----------------
 drivers/staging/fwserial/fwserial.h | 42 ++++++++++++++++++-------------------
 4 files changed, 53 insertions(+), 51 deletions(-)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] staging: fwserial: (coding style) Turning every "unsigned" into "unsigned int" Dominique van den Broeck <domdevlin@free.fr> - 2016-03-29 19:20 +0200
  [PATCH 2/3] staging: fwserial: (coding style) removing "!= NULL" to comply with checkpatch.pl Dominique van den Broeck <domdevlin@free.fr> - 2016-03-29 19:20 +0200
    Re: [PATCH 2/3] staging: fwserial: (coding style) removing "!= NULL"  to comply with checkpatch.pl Peter Hurley <peter@hurleysoftware.com> - 2016-04-01 18:30 +0200
  Re: [PATCH 1/3] staging: fwserial: (coding style) Turning every  "unsigned" into "unsigned int" Peter Hurley <peter@hurleysoftware.com> - 2016-04-01 18:30 +0200

csiph-web