Re: [PATCH 2/6] net: ethernet: renesas: ravb_main: test clock rate to avoid division by 0

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] net: ethernet: renesas: ravb_main: test clock rate to avoid division by 0
Date	Sun, 03 Apr 2016 23:40:01 +0200
Message-ID	<rjXUt-15s-3@gated-at.bofh.it> (permalink)
References	<r8nAZ-682-5@gated-at.bofh.it> <r8nB0-682-13@gated-at.bofh.it>
X-Original-To	linux-kernel@vger.kernel.org
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7JfCtLOvnd9MIVvH"
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	66
Organization	linux.* mail to news gateway
X-Original-Cc	linux-renesas-soc@vger.kernel.org, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, netdev@vger.kernel.org
X-Original-Date	Sun, 3 Apr 2016 23:36:41 +0200
X-Original-Message-ID	<20160403213641.GA24129@katana>
X-Original-References	<1456958018-7849-1-git-send-email-wsa@the-dreams.de> <1456958018-7849-3-git-send-email-wsa@the-dreams.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1370293

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Mar 02, 2016 at 11:33:33PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> The clk API may return 0 on clk_get_rate, so we should check the result before
> using it as a divisor.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Ping.

> ---
> 
> Should go individually via subsystem tree.
> 
>  drivers/net/ethernet/renesas/ravb_main.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 88656ceb6e2946..ce1954a6a12726 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1691,6 +1691,9 @@ static int ravb_set_gti(struct net_device *ndev)
>  	rate = clk_get_rate(clk);
>  	clk_put(clk);
>  
> +	if (!rate)
> +		return -EINVAL;
> +
>  	inc = 1000000000ULL << 20;
>  	do_div(inc, rate);
>  
> -- 
> 2.7.0
> 
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/6] net: ethernet: renesas: ravb_main: test clock rate  to avoid division by 0 Wolfram Sang <wsa@the-dreams.de> - 2016-04-03 23:40 +0200
  Re: [PATCH 2/6] net: ethernet: renesas: ravb_main: test clock rate to  avoid division by 0 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-04 00:30 +0200

csiph-web