[PATCH v2 3/8] block: mark 1st parameter of bvec_iter_advance as const

From	Ming Lei <ming.lei@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 3/8] block: mark 1st parameter of bvec_iter_advance as const
Date	2016-04-03 18:40 +0200
Message-ID	<rjTeb-6bQ-39@gated-at.bofh.it> (permalink)
References	<rjTea-6bQ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

bvec_iter_advance() only writes the parameter of iterator,
so the base address of bvec can be marked as const safely.

Without the change, we can see compiling warning in the
following patch for implementing iterate_bvec(): lib/iov_iter.c
with bvec iterator.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
 include/linux/bvec.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/bvec.h b/include/linux/bvec.h
index e111124..0c6fa42 100644
--- a/include/linux/bvec.h
+++ b/include/linux/bvec.h
@@ -63,7 +63,8 @@ struct bvec_iter {
 	.bv_offset	= bvec_iter_offset((bvec), (iter)),	\
 })
 
-static inline void bvec_iter_advance(struct bio_vec *bv, struct bvec_iter *iter,
+static inline void bvec_iter_advance(const struct bio_vec *bv,
+				     struct bvec_iter *iter,
 				     unsigned bytes)
 {
 	WARN_ONCE(bytes > iter->bi_size,
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/8] block: prepare for multipage bvecs Ming Lei <ming.lei@canonical.com> - 2016-04-03 18:40 +0200
  [PATCH v2 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei <ming.lei@canonical.com> - 2016-04-03 18:40 +0200
  [PATCH v2 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei <ming.lei@canonical.com> - 2016-04-03 18:40 +0200
  [PATCH v2 3/8] block: mark 1st parameter of bvec_iter_advance as const Ming Lei <ming.lei@canonical.com> - 2016-04-03 18:40 +0200

csiph-web