Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early
Date	2016-04-03 16:20 +0200
Message-ID	<rjR2G-4yY-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <rjAbv-IR-1@gated-at.bofh.it> <rjAOe-Z0-1@gated-at.bofh.it> <rjLgB-tH-3@gated-at.bofh.it> <rjQJk-44U-7@gated-at.bofh.it> <rjQJk-44U-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Apr 03, 2016 at 06:55:00AM -0700, Andy Lutomirski wrote:
> > No, please don't fail at early boot.
> >
> > Early boot is just about the *worst* situation to try to debug odd
> > failures, exactly since things like printk may not be reliable, and
> > things won't get logged etc.
> >
> > So particularly during early boot we should try as hard as possible
> > not to crash - even if it means not being able to log about a problem.
> > At least that way you have a hopefully working machine and can *maybe*
> > debug things.
> >
> 
> In this regard, at least, my patch is the right approach.  Calling the
> handler, whatever it is, is less likely to panic than refusing to call
> it.

Ok, good.

But can we pretty please document this whole situation, i.e., the
fact that we're trying really really hard not to fail early boot for
debuggability reasons - either in the commit message or better in the
code, for future reference. I think this is an important aspect to hold
down.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Thread

[PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Andy Lutomirski <luto@kernel.org> - 2016-04-02 16:10 +0200
  Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks  early Borislav Petkov <bp@alien8.de> - 2016-04-02 21:00 +0200
    Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Andy Lutomirski <luto@amacapital.net> - 2016-04-02 22:20 +0200
      Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks  early Borislav Petkov <bp@alien8.de> - 2016-04-02 23:00 +0200
        Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks  early Borislav Petkov <bp@alien8.de> - 2016-04-03 10:10 +0200
          Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Andy Lutomirski <luto@amacapital.net> - 2016-04-03 15:30 +0200
          Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Linus Torvalds <torvalds@linux-foundation.org> - 2016-04-03 16:00 +0200
            Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Andy Lutomirski <luto@amacapital.net> - 2016-04-03 16:00 +0200
              Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Linus Torvalds <torvalds@linux-foundation.org> - 2016-04-03 16:20 +0200
              Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks  early Borislav Petkov <bp@alien8.de> - 2016-04-03 16:20 +0200
                Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Andy Lutomirski <luto@amacapital.net> - 2016-04-04 17:50 +0200
  [tip:x86/asm] x86/traps: Enable all exception handler callbacks  early tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2016-04-13 13:50 +0200

csiph-web