Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1370185
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/1] iio: gyro: bmg160: fix buffer read values |
| Date | 2016-04-03 12:30 +0200 |
| Message-ID | <rjNs6-1W9-5@gated-at.bofh.it> (permalink) |
| References | <rhIZA-1I8-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 28/03/16 18:15, Irina Tirdea wrote:
> When reading gyroscope axes using iio buffers, the values
> returned are always 0. In the interrupt handler, the return
> value of the read operation is returned to the user instead
> of the value read. Return the value read to the user.
>
> This is also fixed in commit 82d8e5da1a33 ("iio:
> accel: bmg160: optimize transfers in trigger handler").
>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Ouch. Applied and marked for stable.
Jonathan
> ---
> drivers/iio/gyro/bmg160_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c
> index 295cf1d..e165ce9 100644
> --- a/drivers/iio/gyro/bmg160_core.c
> +++ b/drivers/iio/gyro/bmg160_core.c
> @@ -781,7 +781,7 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p)
> mutex_unlock(&data->mutex);
> goto err;
> }
> - data->buffer[i++] = ret;
> + data->buffer[i++] = val;
> }
> mutex_unlock(&data->mutex);
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/1] iio: gyro: bmg160: fix buffer read values Irina Tirdea <irina.tirdea@intel.com> - 2016-03-28 19:20 +0200 Re: [PATCH 1/1] iio: gyro: bmg160: fix buffer read values Jonathan Cameron <jic23@kernel.org> - 2016-04-03 12:30 +0200 Re: [PATCH 1/1] iio: gyro: bmg160: fix buffer read values Markus Pargmann <mpa@pengutronix.de> - 2016-04-07 09:00 +0200
csiph-web