Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1369330

Re: [PATCH] perf tools: Fix build errors on tsc functions for archs other than x86

From Adrian Hunter <adrian.hunter@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] perf tools: Fix build errors on tsc functions for archs other than x86
Date 2016-04-01 15:50 +0200
Message-ID <rj7Cx-53r-11@gated-at.bofh.it> (permalink)
References <riYpz-6ZD-1@gated-at.bofh.it> <rj79w-4RA-5@gated-at.bofh.it> <rj7jc-4UU-27@gated-at.bofh.it>
Organization Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki

Show all headers | View raw


On 01/04/16 16:24, Arnaldo Carvalho de Melo wrote:
> Em Fri, Apr 01, 2016 at 10:13:12AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, Apr 01, 2016 at 03:49:32AM +0000, He Kuang escreveu:
>>> Build errors on aarch64:
>>>
>>>   libperf.a(libperf-in.o): In function `convert_timestamp':
>>>   util/jitdump.c:356: undefined reference to `tsc_to_perf_time'
>>>   collect2: error: ld returned 1 exit status
>>>   Makefile.perf:347: recipe for target 'perf' failed
>>>   make[1]: *** [perf] Error 1
>>>   Makefile:68: recipe for target 'all' failed
>>>   make: *** [all] Error 2
>>
>> Got it, my cross-compile environment for aarch64 doesn't build jitdump.c
>> because it needs a package I haven't found in ubuntu:
>>
>> config/Makefile:416: No libcrypto.h found, disables jitted code injection, please install libssl-devel or libssl-dev
>> minimal-ubuntu-x-arm64: Ok
>>
>> BTW, He, what environment do you use to build for arm64, is it a cross
>> compile one? Yocto?
> 
> Adrian, BTW, Ok with this? I'm adding a:
> 
> Fixes: d3e58a3b8b3b ("perf jit: Add support for using TSC as a timestamp")
> 
> And would appreciate your Acked-by.

Sure, already did in http://marc.info/?l=linux-kernel&m=145949505329251

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] perf tools: Fix build errors on tsc functions for archs other than x86 He Kuang <hekuang@huawei.com> - 2016-04-01 06:00 +0200
  Re: [PATCH] perf tools: Fix build errors on tsc functions for archs  other than x86 Adrian Hunter <adrian.hunter@intel.com> - 2016-04-01 09:20 +0200
  Re: [PATCH] perf tools: Fix build errors on tsc functions for archs  other than x86 Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-01 15:20 +0200
    Re: [PATCH] perf tools: Fix build errors on tsc functions for archs  other than x86 Hekuang <hekuang@huawei.com> - 2016-04-01 15:30 +0200
    Re: [PATCH] perf tools: Fix build errors on tsc functions for archs  other than x86 Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-01 15:30 +0200
      Re: [PATCH] perf tools: Fix build errors on tsc functions for archs  other than x86 Adrian Hunter <adrian.hunter@intel.com> - 2016-04-01 15:50 +0200

csiph-web