Re: [PATCH 01/12] mtd: nand: remove unneeded of_mtd.h inclusions

From	Harvey Hunt <harvey.hunt@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/12] mtd: nand: remove unneeded of_mtd.h inclusions
Date	2016-04-01 15:10 +0200
Message-ID	<rj6ZS-4O4-39@gated-at.bofh.it> (permalink)
References	<rj6Q9-4rL-3@gated-at.bofh.it> <rj6Qa-4rL-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Boris,

On 01/04/16 13:54, Boris Brezillon wrote:
> Some drivers are including linux/of_mtd.h even if they don't use any of
> the of_get_nand_xxx() helpers.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
>   drivers/mtd/nand/jz4780_nand.c | 1 -
>   drivers/mtd/nand/lpc32xx_mlc.c | 1 -
>   drivers/mtd/nand/qcom_nandc.c  | 1 -
>   drivers/mtd/nand/sunxi_nand.c  | 1 -
>   drivers/mtd/nand/vf610_nfc.c   | 1 -
>   5 files changed, 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c
> index e1c016c..23a1999 100644
> --- a/drivers/mtd/nand/jz4780_nand.c
> +++ b/drivers/mtd/nand/jz4780_nand.c
> @@ -17,7 +17,6 @@
>   #include <linux/of.h>
>   #include <linux/of_address.h>
>   #include <linux/gpio/consumer.h>
> -#include <linux/of_mtd.h>
>   #include <linux/platform_device.h>
>   #include <linux/slab.h>
>   #include <linux/mtd/mtd.h>

Looks good to me.

Acked-by: Harvey Hunt <harvey.hunt@imgtec.com>

Thanks,

Harvey

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 01/12] mtd: nand: remove unneeded of_mtd.h inclusions Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-01 15:00 +0200
  Re: [PATCH 01/12] mtd: nand: remove unneeded of_mtd.h inclusions Harvey Hunt <harvey.hunt@imgtec.com> - 2016-04-01 15:10 +0200

csiph-web