Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1369146

Re: [PATCH] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag

Show all headers | View raw

On 04/01/2016 12:15 AM, Nishanth Menon wrote:
> Palams extcon IRQs are nested threaded and wired to the Palmas
> inerrupt controller. So, this flag is not required for nested
> irqs anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend
> nested_thread irqs over system suspend") was merged. However, the
> fix missed a stray flag causing the following crash on resume on

Ok. Sry, my bad I've had to check next.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

>
> Fixes: ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME flag")
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Roger Quadros <rogerq@ti.com>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>   drivers/extcon/extcon-palmas.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 841a4b586395..8b3226dca1d9 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -348,8 +348,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
>   						palmas_vbus_irq_handler,
>   						IRQF_TRIGGER_FALLING |
>   						IRQF_TRIGGER_RISING |
> -						IRQF_ONESHOT |
> -						IRQF_EARLY_RESUME,
> +						IRQF_ONESHOT,
>   						"palmas_usb_vbus",
>   						palmas_usb);
>   		if (status < 0) {
>


-- 
regards,
-grygorii

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag Nishanth Menon <nm@ti.com> - 2016-03-31 23:20 +0200
  Re: [PATCH] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-01 01:30 +0200
    Re: [PATCH] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag Nishanth Menon <nm@ti.com> - 2016-04-01 15:10 +0200
  Re: [PATCH] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag Lee Jones <lee.jones@linaro.org> - 2016-04-01 10:00 +0200
    Re: [PATCH] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag Nishanth Menon <nm@ti.com> - 2016-04-01 15:10 +0200
  Re: [PATCH] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-01 12:00 +0200

csiph-web