Re: [PATCH v2 11/11] MIPS: KASLR: Print relocation Information on boot

From	Ralf Baechle <ralf@linux-mips.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 11/11] MIPS: KASLR: Print relocation Information on boot
Date	2016-04-01 10:50 +0200
Message-ID	<rj2We-1Lk-11@gated-at.bofh.it> (permalink)
References	<riGVH-2I1-3@gated-at.bofh.it> <riGVI-2I1-17@gated-at.bofh.it> <riK3h-531-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 31, 2016 at 03:38:10PM +0300, Sergei Shtylyov wrote:

> >When debugging a relocated kernel, the addresses of the relocated
> >symbols and the offset applied is essential information. If the kernel
> >is compiled with debugging information, then print this information
> >during bootup using the same function as the panic notifer.
> 
>    Notifier.

Fixed when merging.

> >Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
> >---
> >
> >Changes in v2: None
> >
> >  arch/mips/kernel/setup.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> >diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> >index d8376d7b3345..ae71f8d9b555 100644
> >--- a/arch/mips/kernel/setup.c
> >+++ b/arch/mips/kernel/setup.c
> >@@ -477,9 +477,18 @@ static void __init bootmem_init(void)
> >  	 */
> >  	if (__pa_symbol(_text) > __pa_symbol(VMLINUX_LOAD_ADDRESS)) {
> >  		unsigned long offset;
> >+		extern void show_kernel_relocation(const char *level);
> >
> >  		offset = __pa_symbol(_text) - __pa_symbol(VMLINUX_LOAD_ADDRESS);
> >  		free_bootmem(__pa_symbol(VMLINUX_LOAD_ADDRESS), offset);
> >+
> >+#if (defined CONFIG_DEBUG_KERNEL) && (defined CONFIG_DEBUG_INFO)
> 
>    Not #if defined(CONFIG_DEBUG_KERNEL) && defined(CONFIG_DEBUG_INFO)?
> 
> [...]

CPP syntax is not what most people seem to believe that is the parenthesis
around the argument of defined are not required so above line is unusual
but perfectly ok.  However following boring standards is good so I changed
this, too.

  Ralf

Thread

[PATCH v2 11/11] MIPS: KASLR: Print relocation Information on boot Matt Redfearn <matt.redfearn@imgtec.com> - 2016-03-31 11:20 +0200
  Re: [PATCH v2 11/11] MIPS: KASLR: Print relocation Information on  boot Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-31 14:40 +0200
    Re: [PATCH v2 11/11] MIPS: KASLR: Print relocation Information on  boot Ralf Baechle <ralf@linux-mips.org> - 2016-04-01 10:50 +0200
      Re: [PATCH v2 11/11] MIPS: KASLR: Print relocation Information on  boot Matt Redfearn <matt.redfearn@imgtec.com> - 2016-04-01 11:10 +0200

csiph-web