Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1369076

[PATCH v3 0/3] ahci: add ports-implemented dt bindings

Show all headers | View raw

Hi Tejun,

On some SOCs PORTS_IMPL register value is never programmed by the BIOS
and left at zero value. Which means that no sata ports are available for
software. AHCI driver used to cope up with this by fabricating the
port_map if the PORTS_IMPL register is read zero, but recent patch [1]
broke this workaround as zero value was valid for nvme disks.

This patch adds ports-implemented dt bindings as workaround for this issue
in a way that DT can dictate the port_map incase where the SOCs does not
program it already.

Am sure that there are more than one SOC that hits this issue.

Without this patchset, ACHI on APQ8064 Qualcomm platform is broken in mainline.
With the below patchset am able to get back the functionality.

Can you take all the patches via libata tree, I have collected the
acks required for DT.

Changes since v2:
	- reordered compatible strings in DT spotted by Sergei.

Changes since RFC:
	- Remove DT example as suggested by Rob.
	- Fixed comments on DT binding patch as suggested by Rob.
	- removed unused variable spotted by kernel test robot.

Thanks,
srini
[1] 566d18 "libata: disable forced PORTS_IMPL for >= AHCI 1.3"

Srinivas Kandagatla (3):
  libahci: save port map for forced port map
  ata: ahci-platform: Add ports-implemented DT bindings.
  ARM: dts: apq8064: add ahci ports-implemented mask

 Documentation/devicetree/bindings/ata/ahci-platform.txt | 4 ++++
 arch/arm/boot/dts/qcom-apq8064.dtsi                     | 3 ++-
 drivers/ata/ahci_platform.c                             | 3 +++
 drivers/ata/libahci.c                                   | 1 +
 4 files changed, 10 insertions(+), 1 deletion(-)

-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] ahci: add ports-implemented dt bindings Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-01 10:00 +0200
  [PATCH v3 1/3] libahci: save port map for forced port map Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-01 10:00 +0200
  [PATCH v3 2/3] ata: ahci-platform: Add ports-implemented DT bindings. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-01 10:00 +0200
  [PATCH v3 3/3] ARM: dts: apq8064: add ahci ports-implemented mask Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-01 10:00 +0200
  Re: [PATCH v3 0/3] ahci: add ports-implemented dt bindings Tejun Heo <tj@kernel.org> - 2016-04-01 16:50 +0200

csiph-web