Re: [PATCH] android: lmk: add swap pte pmd in tasksize

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] android: lmk: add swap pte pmd in tasksize
Date	Thu, 31 Mar 2016 03:30:02 +0200
Message-ID	<rizAS-5C4-7@gated-at.bofh.it> (permalink)
References	<rbpGi-2IW-11@gated-at.bofh.it> <rbpPZ-2Oc-39@gated-at.bofh.it> <rbrf3-3Sw-17@gated-at.bofh.it> <rbyTg-161-17@gated-at.bofh.it> <rcpuy-58k-9@gated-at.bofh.it>
X-Original-To	Chen Feng <puck.chen@hisilicon.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	yalin wang <yalin.wang2010@gmail.com>, Lu Bing <albert.lubing@hisilicon.com>, devel@driverdev.osuosl.org, dan.zhao@hisilicon.com, chenxiang9@huawei.com, xuyiping@hisilicon.com, suzhuangluan@hisilicon.com, linuxarm@huawei.com, riandrews@android.com, alan.wei@hisilicon.com, linux-kernel@vger.kernel.org, arve@android.com, saberlily.xia@hisilicon.com, shimingxing@hisilicon.com, oliver.fu@hisilicon.com, liuzixing@huawei.com, yudongbin@hisilicon.com, kirill.shutemov@linux.intel.com
X-Original-Date	Wed, 30 Mar 2016 18:26:00 -0700
X-Original-Message-ID	<20160331012600.GC28422@kroah.com>
X-Original-References	<1457681032-178195-1-git-send-email-albert.lubing@hisilicon.com> <8DA5D99D-7542-4ABB-9DB4-076B255A5F75@gmail.com> <56E28A69.9040409@hisilicon.com> <20160311171213.GA1458@kroah.com> <56E61328.8000101@hisilicon.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1367735

Show key headers only | View raw

On Mon, Mar 14, 2016 at 09:26:00AM +0800, Chen Feng wrote:
> Hi greg,
> 
> On 2016/3/12 1:12, Greg KH wrote:
> > On Fri, Mar 11, 2016 at 05:05:45PM +0800, Chen Feng wrote:
> >>
> >>
> >> On 2016/3/11 15:30, yalin wang wrote:
> >>>
> >>>> On Mar 11, 2016, at 15:23, Lu Bing <albert.lubing@hisilicon.com> wrote:
> >>>>
> >>>> From: l00215322 <albert.lubing@hisilicon.com>
> >>>>
> >>>> Many android devices have zram,so we should add "MM_SWAPENTS" in tasksize.
> >>>> Refer oom_kill.c,we add pte&pmd also.
> >>>>
> >>>> Reviewed-by: Chen Feng <puck.chen@hisilicon.com>
> >>>> Reviewed-by: Fu Jun <oliver.fu@hisilicon.com>
> >>>> Reviewed-by: Xu YiPing <xuyiping@hisilicon.com>
> >>>> Reviewed-by: Yu DongBin <yudongbin@hisilicon.com>
> >>>> Signed-off-by: Lu Bing <albert.lubing@hisilicon.com>
> >>>> ---
> >>>> drivers/staging/android/lowmemorykiller.c | 4 +++-
> >>>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
> >>>> index 8b5a4a8..0817d3b 100644
> >>>> --- a/drivers/staging/android/lowmemorykiller.c
> >>>> +++ b/drivers/staging/android/lowmemorykiller.c
> >>>> @@ -139,7 +139,9 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc)
> >>>> 			task_unlock(p);
> >>>> 			continue;
> >>>> 		}
> >>>> -		tasksize = get_mm_rss(p->mm);
> >>>> +		tasksize = get_mm_rss(p->mm) +
> >>>> +			get_mm_counter(p->mm, MM_SWAPENTS) +
> >>>> +			atomic_long_read(&p->mm->nr_ptes) + mm_nr_pmds(p->mm);
> >>> why not introduce a mm_nr_ptes()  help function here ?
> >>> more clear to see .
> >>>
> >> Since the code is in staging, we can add another patch to do this.
> > 
> > I do not understand this, please explain.
> > 
> I mean that we can submit another patch to add mm_nr_ptes() in mm-module and replace the code used nr_ptes
> with this interface(mm_nr_ptes()).
> 
> This patch is just change the score of task-size in low memory killer.

Ok, I'll drop this from my queue.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] android: lmk: add swap pte pmd in tasksize Greg KH <gregkh@linuxfoundation.org> - 2016-03-31 03:30 +0200

csiph-web