Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367667

Re: [PATCH] regulator: Fix deadlock during regulator registration

From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH] regulator: Fix deadlock during regulator registration
Date 2016-03-31 01:40 +0200
Message-ID <rixSp-4h4-1@gated-at.bofh.it> (permalink)
References <riqQV-7Ua-3@gated-at.bofh.it> <rixIK-4bU-17@gated-at.bofh.it> <rixSp-4h4-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hello Mark,

On 03/30/2016 07:34 PM, Mark Brown wrote:
> On Wed, Mar 30, 2016 at 07:25:49PM -0400, Javier Martinez Canillas wrote:
> 
>> You are doing some cleanup of the clean and scrub error paths by removing
>> rdev and returning ERR_PTR(ret) directly. I believe that should be in a
>> separate patch since is not related to the fix.
> 
> There needs to be some reorganization due to the movement with the mutex
> handling.
> 

Yes, I know. My point was that besides the reorganization that is needed,
he is removing some variables and that seemed like a separate change to me.

But of course you are the maintainer so ignore my comment if you don't mind
about that.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: Fix deadlock during regulator registration Jon Hunter <jonathanh@nvidia.com> - 2016-03-30 18:10 +0200
  Re: [PATCH] regulator: Fix deadlock during regulator registration Mark Brown <broonie@kernel.org> - 2016-03-30 18:20 +0200
    Re: [PATCH] regulator: Fix deadlock during regulator registration Jon Hunter <jonathanh@nvidia.com> - 2016-03-30 18:50 +0200
      Re: [PATCH] regulator: Fix deadlock during regulator registration Mark Brown <broonie@kernel.org> - 2016-03-30 19:10 +0200
        Re: [PATCH] regulator: Fix deadlock during regulator registration Jon Hunter <jonathanh@nvidia.com> - 2016-03-30 19:50 +0200
  Re: [PATCH] regulator: Fix deadlock during regulator registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-31 01:30 +0200
    Re: [PATCH] regulator: Fix deadlock during regulator registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-31 01:40 +0200
    Re: [PATCH] regulator: Fix deadlock during regulator registration Mark Brown <broonie@kernel.org> - 2016-03-31 01:40 +0200

csiph-web