[PATCH 2/2] btrfs: avoid overflowing f_bfree

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] btrfs: avoid overflowing f_bfree
Date	2016-03-30 23:00 +0200
Message-ID	<rivnA-2si-5@gated-at.bofh.it> (permalink)
References	<rivnA-2si-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Since mixed block groups accounting isn't byte-accurate and f_bree is an
unsigned integer, it could overflow. Avoid this.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Suggested-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/super.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index bdca79c..93376d0 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -2101,6 +2101,11 @@ static int btrfs_statfs(struct dentry *dentry, struct kstatfs *buf)
 	/* Account global block reserve as used, it's in logical size already */
 	spin_lock(&block_rsv->lock);
 	buf->f_bfree -= block_rsv->size >> bits;
+	/* Mixed block groups accounting is not byte-accurate, avoid overflow */
+	if (buf->f_bfree >= block_rsv->size >> bits)
+		buf->f_bfree -= block_rsv->size >> bits;
+	else
+		buf->f_bfree = 0;
 	spin_unlock(&block_rsv->lock);
 
 	buf->f_bavail = div_u64(total_free_data, factor);
-- 
2.5.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] btrfs: avoid overflowing f_bfree Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-30 23:00 +0200
  Re: [PATCH 2/2] btrfs: avoid overflowing f_bfree Filipe Manana <fdmanana@gmail.com> - 2016-03-30 23:50 +0200
    Re: [PATCH 2/2] btrfs: avoid overflowing f_bfree Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-31 00:20 +0200

csiph-web