Re: [RFC PATCH 1/3] libahci: save port map for forced port map

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/3] libahci: save port map for forced port map
Date	2016-03-30 21:00 +0200
Message-ID	<ritvs-1a3-17@gated-at.bofh.it> (permalink)
References	<ri1IT-6LW-21@gated-at.bofh.it> <ri1IT-6LW-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Tue, Mar 29, 2016 at 02:11:13PM +0100, Srinivas Kandagatla wrote:
> In usecases where force_port_map is used saved_port_map is never set,
> resulting in not programming the PORTS_IMPL register as part of intial
> config. This patch fixes this by setting it to port_map even in case
> where force_port_map is used, making it more inline with other parts of
> the code.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/ata/libahci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> index 3982054..a5d7c1c 100644
> --- a/drivers/ata/libahci.c
> +++ b/drivers/ata/libahci.c
> @@ -507,6 +507,7 @@ void ahci_save_initial_config(struct device *dev, struct ahci_host_priv *hpriv)
>  		dev_info(dev, "forcing port_map 0x%x -> 0x%x\n",
>  			 port_map, hpriv->force_port_map);
>  		port_map = hpriv->force_port_map;
> +		hpriv->saved_port_map = port_map;

So, the only change it'd cause is making the driver write the forced
value to the PI register.  Does that make sense?

Thanks.

-- 
tejun

Thread

[RFC PATCH 0/3] ahci: add ports-implemented dt bindings. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-03-29 15:20 +0200
  [RFC PATCH 1/3] libahci: save port map for forced port map Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-03-29 15:20 +0200
    Re: [RFC PATCH 1/3] libahci: save port map for forced port map Tejun Heo <tj@kernel.org> - 2016-03-30 21:00 +0200
      Re: [RFC PATCH 1/3] libahci: save port map for forced port map Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-03-31 18:00 +0200
        Re: [RFC PATCH 1/3] libahci: save port map for forced port map Tejun Heo <tj@kernel.org> - 2016-03-31 18:50 +0200
          Re: [RFC PATCH 1/3] libahci: save port map for forced port map Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-03-31 19:00 +0200
  [RFC PATCH 2/3] ata: ahci-platform: Add ports-implemented dt bindings. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-03-29 15:20 +0200
    Re: [RFC PATCH 2/3] ata: ahci-platform: Add ports-implemented dt bindings. Rob Herring <robh+dt@kernel.org> - 2016-03-29 16:20 +0200
      Re: [RFC PATCH 2/3] ata: ahci-platform: Add ports-implemented dt  bindings. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-03-29 16:50 +0200
        Re: [RFC PATCH 2/3] ata: ahci-platform: Add ports-implemented dt bindings. Rob Herring <robh+dt@kernel.org> - 2016-03-29 19:10 +0200
          Re: [RFC PATCH 2/3] ata: ahci-platform: Add ports-implemented dt  bindings. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-03-29 19:20 +0200

csiph-web