Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1367508
| From | Timur Tabi <timur@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART |
| Date | 2016-03-30 20:20 +0200 |
| Message-ID | <risSK-OW-5@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <rcU5k-Bl-3@gated-at.bofh.it> <rinzI-5mS-5@gated-at.bofh.it> <rirDl-8fh-19@gated-at.bofh.it> <rirN1-87-23@gated-at.bofh.it> <risJ5-Lt-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Greg Kroah-Hartman wrote: > On Wed, Mar 30, 2016 at 12:01:56PM -0500, Timur Tabi wrote: >> Greg Kroah-Hartman wrote: >>> If this isn't a bug fix or regression fix, it's not ok for 4.6-final, it >>> will have to wait for 4.7-rc1. >> >> It fixes a problem on our platform (QDF2432). Without this patch, we can't >> use the PL011 at all. > > Did it ever work before? Or is this new functionality? No, it never worked before, so it's not a regression. I guess it all depends on how you define "fix". The driver loads and attempts to use the hardware, but it fails without this patch. The system locks up completely (I guess it throws an unhandled exception or something). I guess if you take a very limited definition of "fix", then this isn't a fix. I can understand if you didn't want to take it for 4.6-rc7 or something, but for 4.6-rc2, I don't think it's inappropriate. That's my two cents. We'd like to see it in 4.6-rc2, but the decision is yours. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation collaborative project.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART Christopher Covington <cov@codeaurora.org> - 2016-03-30 14:40 +0200
Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-30 19:00 +0200
Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART Timur Tabi <timur@codeaurora.org> - 2016-03-30 19:10 +0200
Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-30 20:10 +0200
Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART Timur Tabi <timur@codeaurora.org> - 2016-03-30 20:20 +0200
[PATCH v3] tty: amba-pl011: Use 32-bit accesses for SBSA UART Christopher Covington <cov@codeaurora.org> - 2016-04-01 23:30 +0200
csiph-web