Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1367109
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/6] pinctrl: baytrail: Add pin control data structures |
| Date | 2016-03-30 13:20 +0200 |
| Message-ID | <rimkh-4wo-9@gated-at.bofh.it> (permalink) |
| References | <rhFoZ-7Hz-3@gated-at.bofh.it> <rhFp0-7Hz-29@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Mon, Mar 28, 2016 at 04:29:35PM +0300, Cristina Ciocan wrote:
> +/* SCORE pins */
> +static const struct pinctrl_pin_desc byt_score_pins[] = {
> + PINCTRL_PIN(0, "SATA_GP[0]"), /* GPIOC_0 */
> + PINCTRL_PIN(1, "SATA_GP[1]"), /* GPIOC_1 */
Maybe we should call these "SATA_GP0" and "SATA_GP1" like we do in other
Intel pinctrl drivers?
Also I don't think /* GPIOC_1 */ is really useful comment as that can be
derived already from the pin number.
Otherwise this looks good.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/6] pinctrl: baytrail: Add pin control data structures Cristina Ciocan <cristina.ciocan@intel.com> - 2016-03-28 15:30 +0200
Re: [PATCH v2 1/6] pinctrl: baytrail: Add pin control data structures Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-03-30 13:20 +0200
Re: [PATCH v2 1/6] pinctrl: baytrail: Add pin control data structures Cristina Ciocan <cristina.ciocan@intel.com> - 2016-03-30 13:40 +0200
Re: [PATCH v2 1/6] pinctrl: baytrail: Add pin control data structures Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-03-30 13:50 +0200
csiph-web