Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367094

[tip:core/urgent] uapi/linux/stddef.h: Provide __always_inline to userspace headers

Show all headers | View raw

Commit-ID:  283d757378371e8044d873e661b1dccee46c5887
Gitweb:     http://git.kernel.org/tip/283d757378371e8044d873e661b1dccee46c5887
Author:     Denys Vlasenko <dvlasenk@redhat.com>
AuthorDate: Wed, 30 Mar 2016 00:14:57 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 30 Mar 2016 12:50:17 +0200

uapi/linux/stddef.h: Provide __always_inline to userspace headers

Josh Boyer reported that my recent change to uapi/linux/swab.h broke the Qemu build:

  bc27fb68aaad ("include/uapi/linux/byteorder, swab: force inlining of some byteswap operations")

Unfortunately, UAPI headers don't include compiler.h so fixing it there is not enough,
add an __always_inline definition to uapi/linux/stddef.h instead.

Testcase: "make headers_install" and try to compile this:

	#include <linux/swab.h>
	void main() {}

Reported-by: Josh Boyer <jwboyer@fedoraproject.org>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Thomas Graf <tgraf@suug.ch>
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/1459289697-12875-1-git-send-email-dvlasenk@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 include/uapi/linux/stddef.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/uapi/linux/stddef.h b/include/uapi/linux/stddef.h
index aa9f104..621fa8a 100644
--- a/include/uapi/linux/stddef.h
+++ b/include/uapi/linux/stddef.h
@@ -1 +1,5 @@
 #include <linux/compiler.h>
+
+#ifndef __always_inline
+#define __always_inline inline
+#endif

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] uapi/linux/stddef.h: Provide __always_inline to userspace headers Denys Vlasenko <dvlasenk@redhat.com> - 2016-03-30 00:20 +0200
  [tip:core/urgent] uapi/linux/stddef.h: Provide __always_inline to  userspace headers tip-bot for Denys Vlasenko <tipbot@zytor.com> - 2016-03-30 13:00 +0200
  Re: [PATCH] uapi/linux/stddef.h: Provide __always_inline to userspace headers Josh Boyer <jwboyer@fedoraproject.org> - 2016-03-30 22:10 +0200

csiph-web