Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367090

Re: [PATCH] usb: rework CONFIG_USB_COMMON logic

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Arnd Bergmann <arnd@arndb.de> writes:
> [ text/plain ]
> The phy-am335x driver selects 'USB_COMMON', but all other drivers
> use 'depends on' for that symbol, and it depends on USB || USB_GADGET
> itself, which causes a Kconfig warning:
>
> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))
>
> As suggested by Felipe Balbi, this turns the logic around, and makes
> 'USB_COMMON' selected by everything else that needs it, so we can
> remove the dependencies.
>
> Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Felipe Balbi <balbi@kernel.org>
> Reviewed-by: Peter Chen <peter.chen@nxp.com>
> ---
> I seem to have dropped the ball on this one after my initial submission
> when it wasn't clear who should merge the patch.
>
> Please apply to the USB or the USB gadget tree, whoever gets there
> first.

seems like this is one of those "can wait for next merge window" right ?
I'll take it through my tree. No issues.

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: rework CONFIG_USB_COMMON logic Arnd Bergmann <arnd@arndb.de> - 2016-03-23 17:50 +0100
  Re: [PATCH] usb: rework CONFIG_USB_COMMON logic Felipe Balbi <balbi@kernel.org> - 2016-03-30 12:40 +0200
    Re: [PATCH] usb: rework CONFIG_USB_COMMON logic Felipe Balbi <balbi@kernel.org> - 2016-03-30 16:00 +0200
    Re: [PATCH] usb: rework CONFIG_USB_COMMON logic Arnd Bergmann <arnd@arndb.de> - 2016-03-30 16:00 +0200

csiph-web