Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367055

Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support

Show all headers | View raw

Hi Jose,

On 28 March 2016 at 15:36, Jose Abreu <Jose.Abreu@synopsys.com> wrote:
> This patch adds audio support for the ADV7511 HDMI transmitter
> using ALSA SoC.
>
> The code was ported from Analog Devices linux tree from
> commit 1770c4a1e32b ("Merge remote-tracking branch
> 'xilinx/master' into xcomm_zynq"), which is available at:
>         - https://github.com/analogdevicesinc/linux/
>
> The main core file was renamed from adv7511.c to adv7511_core.c
> so that audio and video compile into a single adv7511.ko module
> and to keep up with Analog Devices kernel tree.
>
> The audio can be disabled using menu-config so it is possible
> to use only video mode.
>
> The HDMI mode is automatically started at boot and the audio
> (when enabled) registers as a codec into ALSA.
>
> SPDIF DAI format was also added to ASoC as it is required
> by adv7511 audio.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> ---
>
> No changes v1 -> v2.
>
>  drivers/gpu/drm/i2c/Kconfig         |   11 +
>  drivers/gpu/drm/i2c/Makefile        |    2 +
>  drivers/gpu/drm/i2c/adv7511.c       | 1024 -----------------------------------
>  drivers/gpu/drm/i2c/adv7511.h       |   41 ++
>  drivers/gpu/drm/i2c/adv7511_audio.c |  310 +++++++++++
>  drivers/gpu/drm/i2c/adv7511_core.c  | 1005 ++++++++++++++++++++++++++++++++++
Please keep the file rename separate (and use -M flag when generating
the patch) from the introduction of audio support. Having to check 1k
LOC movement alongside the introduction of new one is a bit...
suboptimal.

Regards,
Emil

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3 v2] Add I2S/ADV7511 audio support for ARC AXS10x boards Jose Abreu <Jose.Abreu@synopsys.com> - 2016-03-28 16:40 +0200
  Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support Archit Taneja <architt@codeaurora.org> - 2016-03-29 10:10 +0200
    Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support Jose Abreu <Jose.Abreu@synopsys.com> - 2016-03-29 13:00 +0200
      Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support Archit Taneja <architt@codeaurora.org> - 2016-03-29 19:10 +0200
        Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support Jose Abreu <Jose.Abreu@synopsys.com> - 2016-03-31 15:00 +0200
  Re: [PATCH 0/3 v2] Add I2S/ADV7511 audio support for ARC AXS10x  boards Mark Brown <broonie@kernel.org> - 2016-03-29 19:10 +0200
  Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support Emil Velikov <emil.l.velikov@gmail.com> - 2016-03-30 12:00 +0200
  Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-04-01 19:20 +0200

csiph-web