Re: [PATCH 04/11] mm/slab: factor out kmem_cache_node initialization code

From	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/11] mm/slab: factor out kmem_cache_node initialization code
Date	2016-03-30 10:20 +0200
Message-ID	<rijw5-2y5-1@gated-at.bofh.it> (permalink)
References	<rhxUt-2rs-3@gated-at.bofh.it> <rhxUv-2rs-21@gated-at.bofh.it> <rhQaK-6GM-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 28, 2016 at 07:56:15PM -0500, Christoph Lameter wrote:
> On Mon, 28 Mar 2016, js1304@gmail.com wrote:
> 
> > From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> > -		spin_lock_irq(&n->list_lock);
> > -		n->free_limit =
> > -			(1 + nr_cpus_node(node)) *
> > -			cachep->batchcount + cachep->num;
> > -		spin_unlock_irq(&n->list_lock);
> > +		ret = init_cache_node(cachep, node, GFP_KERNEL);
> > +		if (ret)
> > +			return ret;
> 
> Drop ret and do a
> 
> 	return init_cache_node(...);
> 
> instead?

Will do it.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 04/11] mm/slab: factor out kmem_cache_node initialization code js1304@gmail.com - 2016-03-28 07:30 +0200
  Re: [PATCH 04/11] mm/slab: factor out kmem_cache_node initialization  code Christoph Lameter <cl@linux.com> - 2016-03-29 03:00 +0200
    Re: [PATCH 04/11] mm/slab: factor out kmem_cache_node initialization  code Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-03-30 10:20 +0200

csiph-web