Re: [PATCH v3] sched/deadline: do not try to push tasks if pinned task switches to dl

From	Wanpeng Li <kernellwp@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] sched/deadline: do not try to push tasks if pinned task switches to dl
Date	2016-03-30 10:00 +0200
Message-ID	<rijcJ-2aT-11@gated-at.bofh.it> (permalink)
References	<odS82-1JI-15@gated-at.bofh.it> <oe0yC-67f-33@gated-at.bofh.it> <riaCt-4qk-7@gated-at.bofh.it> <rii6Z-1t9-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-03-30 14:44 GMT+08:00 Peter Zijlstra <peterz@infradead.org>:
> On Tue, Mar 29, 2016 at 06:47:22PM -0400, Steven Rostedt wrote:
>> I'm looking at some old changes for sched-deadline, and I stumbled
>> across this. As I'm working on sched deadline tests, I've discovered
>> that they can't have cpu affinity. They are limited to their sched
>> domains. That is, sched deadline tasks have whatever affinity that the

root domain I think.

>> domain they happen to be in has.
>>
>> Is there a condition where rq != task_rq(p) and p->nr_cpus_allowed > 1
>> isn't true?
>
> When holding rq->lock, no. I suppose the patch was just to mirror rt and
> someone 'forgot' about the extra constraints on dl tasks.
>

sched_class::switched_from() methods can drop rq->lock before your
great balance_callback patchset. :-)

Regards,
Wanpeng Li

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] sched/deadline: do not try to push tasks if pinned  task switches to dl Steven Rostedt <rostedt@goodmis.org> - 2016-03-30 00:50 +0200
  Re: [PATCH v3] sched/deadline: do not try to push tasks if pinned  task switches to dl Peter Zijlstra <peterz@infradead.org> - 2016-03-30 08:50 +0200
    Re: [PATCH v3] sched/deadline: do not try to push tasks if pinned  task switches to dl Wanpeng Li <kernellwp@gmail.com> - 2016-03-30 10:00 +0200

csiph-web