Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367018

Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

Show all headers | View raw

On 03/30/2016 10:17 AM, Jisheng Zhang wrote:
> On Wed, 30 Mar 2016 10:09:12 +0200 Daniel Lezcano wrote:
>
>> On 03/30/2016 09:16 AM, Jisheng Zhang wrote:
>>> Hi Daniel,
>>
>> [ ... ]
>>
>> Added Lorenzo and Catalin.
>>
>>>> Hi Jisheng,
>>>>
>>>> this should be handled in the arm_cpuidle_read_ops function.
>>>>
>>>
>>> Thanks for reviewing. After some consideration, I think this patch isn't correct
>>> There may be platforms which doesn't need the init member at all, although
>>> currently I don't see such platforms in mainline, So I'll drop this patch
>>> and send out one v2 only does the optimization.
>>
>> There is an inconsistency between ARM and ARM64. The 'cpu_get_ops', the
>> arm_cpuidle_read_ops from the ARM64 side, returns -EOPNOTSUPP when the
>> init function is not there for cpuidle.
>
> yes.
> arm64's arm_cpuidle_init() returns -EOPNOTSUPP if init callback isn't defined
>
>>
>> I don't think it is a problem, but as ARM/ARM64 are sharing the same
>> cpuidle-arm.c driver it would make sense to unify the behavior between
>> both archs.
>
> yes, agree with you. From "unify" point of view, could I move back the suspend
> callback check and init callback check into arm_cpuidle_init() for arm as V1 does?

Why ? To be consistent with ARM64 ?


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] ARM: cpuidle: bug fix and a trivial improvement Jisheng Zhang <jszhang@marvell.com> - 2016-03-24 06:20 +0100
  [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init Jisheng Zhang <jszhang@marvell.com> - 2016-03-24 06:20 +0100
    Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during  init Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-03-25 12:50 +0100
      Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case  during init Jisheng Zhang <jszhang@marvell.com> - 2016-03-30 09:30 +0200
        Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during  init Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-03-30 10:20 +0200
          Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case  during init Jisheng Zhang <jszhang@marvell.com> - 2016-03-30 10:30 +0200
            Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case  during init Jisheng Zhang <jszhang@marvell.com> - 2016-03-30 10:50 +0200
              Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during  init Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-03-30 11:40 +0200
                Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case  during init Jisheng Zhang <jszhang@marvell.com> - 2016-03-30 11:50 +0200
            Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during  init Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-03-30 10:50 +0200
          Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during  init Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-03-30 12:40 +0200
  [PATCH 2/2] ARM: cpuidle: make arm_cpuidle_suspend() a bit more efficient Jisheng Zhang <jszhang@marvell.com> - 2016-03-24 06:20 +0100
    Re: [PATCH 2/2] ARM: cpuidle: make arm_cpuidle_suspend() a bit more  efficient Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-03-25 13:00 +0100

csiph-web