Re: [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM
Date	2016-03-30 10:30 +0200
Message-ID	<rijFM-2CP-15@gated-at.bofh.it> (permalink)
References	<ricuB-5QH-3@gated-at.bofh.it> <rijmp-2uB-1@gated-at.bofh.it> <rijw5-2y5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 30.03.2016 17:10, Lee Jones wrote:
> On Wed, 30 Mar 2016, Lee Jones wrote:
> 
>> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
>>
>>> The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
>>> direct dependencies.
>>>
>>> This fixes warning on allyesconfig on ARCH=um:
>>>
>>> warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X &&
>>> 	DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW
>>> 	&& PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE &&
>>> 	S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK &&
>>> 	RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM &&
>>> 	ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB)
>>> selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> Acked-by: Lee Jones <lee.jones@linaro.org>
>>
>> Holding off on this until the discussion reaches some kind of
>> consensus.
> 
> FYI: https://lkml.org/lkml/2016/3/29/716

Yes, Rob's solution looks better to me.

BR,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-30 02:50 +0200
  Re: [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on  HAS_IOMEM Lee Jones <lee.jones@linaro.org> - 2016-03-30 10:10 +0200
    Re: [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on  HAS_IOMEM Lee Jones <lee.jones@linaro.org> - 2016-03-30 10:20 +0200
      Re: [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-30 10:30 +0200

csiph-web