Re: [PATCH] fs/vfs: improve __mnt_is_readonly

From	Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fs/vfs: improve __mnt_is_readonly
Date	2016-03-30 03:30 +0200
Message-ID	<rid7k-6mj-5@gated-at.bofh.it> (permalink)
References	<rgpmi-391-3@gated-at.bofh.it> <rgKAq-1me-1@gated-at.bofh.it> <rhVtM-2bq-11@gated-at.bofh.it> <rhYrD-46p-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 29, 2016 at 11:43:21AM +0200, Richard Weinberger wrote:
> On Tue, Mar 29, 2016 at 8:35 AM, Yaowei Bai
> <baiyaowei@cmss.chinamobile.com> wrote:
> > On Sat, Mar 26, 2016 at 12:43:32AM +0000, Al Viro wrote:
> >> On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote:
> >> > This patch refactors __mnt_is_readonly and makes it return bool to
> >> > improve readability due to this particular function only using either
> >> > one or zero as its return value.
> >>
> >> Improve in which way, if I may ask?
> >
> > A boolean return value can be more matchable with function's name and
> > more suitable as this function only returns 0/1.
> 
> Please also think of the arguments made on linux-mtd[1].
> Hopping from one subsystem to another trying to sneak patches
> in is not the best idea... :-)

Acturally, this patch was sent before the mtd ones and all of them were sent
in one shot. You're really thinking too much.:-)

> 
> [1]: http://lists.infradead.org/pipermail/linux-mtd/2016-March/066296.html
> 
> -- 
> Thanks,
> //richard

Thread

[PATCH] fs/vfs: improve __mnt_is_readonly Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-25 03:10 +0100
  Re: [PATCH] fs/vfs: improve __mnt_is_readonly Al Viro <viro@ZenIV.linux.org.uk> - 2016-03-26 01:50 +0100
    Re: [PATCH] fs/vfs: improve __mnt_is_readonly Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-29 08:40 +0200
      Re: [PATCH] fs/vfs: improve __mnt_is_readonly Richard Weinberger <richard.weinberger@gmail.com> - 2016-03-29 11:50 +0200
        Re: [PATCH] fs/vfs: improve __mnt_is_readonly Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2016-03-30 03:30 +0200
          Re: [PATCH] fs/vfs: improve __mnt_is_readonly Richard Weinberger <richard@nod.at> - 2016-03-30 09:40 +0200

csiph-web