Re: [PATCH v2] vfs: constify arguments to utime family of system calls

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] vfs: constify arguments to utime family of system calls
Date	2016-04-01 05:40 +0200
Message-ID	<riY6d-6RZ-1@gated-at.bofh.it> (permalink)
References	<riWxs-5uU-11@gated-at.bofh.it> <riWH9-5RD-13@gated-at.bofh.it> <riX0t-65Z-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 31, 2016 at 09:24:57PM -0500, Eric Biggers wrote:

> I feel it's a small improvement as it reduces the chance of bugs.  However, if
> you look at all the system calls, they are, in general, inconsistent about using
> 'const'.  So may be right that changing just a few isn't worthwhile.

It might very well be worth doing a full series, though - after all,
they are not hard to grep for ((COMPAT_)?SYSCALL_DEFINE[0-6] would get
you almost all of them, with rest consisting of weird shit in arch/*
that more often than not would be better off switched to SYSCALL_DEFINE).

The reason why it's worth doing completely or not at all is that partial
series will serve as an invitation to the alt.sex.masturbation.commit.count
crowd, with the usual quality of output...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] vfs: constify arguments to utime family of system calls Eric Biggers <ebiggers3@gmail.com> - 2016-04-01 04:00 +0200
  Re: [PATCH v2] vfs: constify arguments to utime family of system  calls Al Viro <viro@ZenIV.linux.org.uk> - 2016-04-01 04:10 +0200
    Re: [PATCH v2] vfs: constify arguments to utime family of system  calls Eric Biggers <ebiggers3@gmail.com> - 2016-04-01 04:30 +0200
      Re: [PATCH v2] vfs: constify arguments to utime family of system  calls Al Viro <viro@ZenIV.linux.org.uk> - 2016-04-01 05:40 +0200

csiph-web