Re: [PATCH] kernfs: Move faulting copy_user operations outside of the mutex

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kernfs: Move faulting copy_user operations outside of the mutex
Date	2016-03-31 22:20 +0200
Message-ID	<riRes-1PN-45@gated-at.bofh.it> (permalink)
References	<riIkN-3DO-7@gated-at.bofh.it> <riNXc-7Uj-15@gated-at.bofh.it> <riOJA-8tH-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 31, 2016 at 08:30:05PM +0300, Joonas Lahtinen wrote:
> On to, 2016-03-31 at 12:49 -0400, Tejun Heo wrote:
> > On Thu, Mar 31, 2016 at 11:45:06AM +0100, Chris Wilson wrote:
> > > 
> > > A fault in a user provided buffer may lead anywhere, and lockdep warns
> > > that we have a potential deadlock between the mm->mmap_sem and the
> > > kernfs file mutex:
> > ...
> > > 
> > > Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94350
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Tejun Heo <tj@kernel.org>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: NeilBrown <neilb@suse.de>
> > > Cc: linux-kernel@vger.kernel.org
> > Acked-by: Tejun Heo <tj@kernel.org>
> > 
> 
> Thanks.
> 
> I have applied this locally to our repo to be included into our CI
> builds.
> 
> We will drop the local patch once this waterfalls from upstream to our
> drm-intel-nightly repo.

So is this something that needs to get into 4.6-final because it
resolves a reported issue?  Or can it wait for 4.7-rc1?

thanks,

greg k-h

Thread

[PATCH] kernfs: Move faulting copy_user operations outside of the mutex Chris Wilson <chris@chris-wilson.co.uk> - 2016-03-31 12:50 +0200
  Re: [PATCH] kernfs: Move faulting copy_user operations outside of  the mutex Tejun Heo <tj@kernel.org> - 2016-03-31 18:50 +0200
    Re: [PATCH] kernfs: Move faulting copy_user operations outside of  the mutex Joonas Lahtinen <joonas.lahtinen@linux.intel.com> - 2016-03-31 19:40 +0200
      Re: [PATCH] kernfs: Move faulting copy_user operations outside of  the mutex Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-31 22:20 +0200
        Re: [PATCH] kernfs: Move faulting copy_user operations outside of  the mutex Joonas Lahtinen <joonas.lahtinen@linux.intel.com> - 2016-04-01 08:20 +0200

csiph-web