Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1368511

Re: [PATCH] regulator: core: Use parent voltage from the supply when bypassed

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Mar 31, 2016 at 03:27:58PM +0100, Jon Hunter wrote:
> On 30/03/16 18:32, Mark Brown wrote:

> > +		if (bypassed) {
> > +			if (rdev->supply) {
> > +				ret = _regulator_get_voltage(rdev->supply->rdev);

> Should this be a return here?

Gnargh, yes.

> I gave this a quick test on tegra124 having populated the
> get/set_bypass() operators for the as3722. In this case, there is still
> a problem because _regulator_get_voltage() is called during regulator
> registration when set_machine_constraints() is called, which is before
> we have called regulator_register_resolve_supply(). Therefore, it seems
> to me that we still need to resolve the supply before we call
> set_machine_constraints().

OK, we need to change the code there to defer probe in the case where
the device is in bypass mode as well.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: core: Use parent voltage from the supply when bypassed Mark Brown <broonie@kernel.org> - 2016-03-30 19:40 +0200
  Re: [PATCH] regulator: core: Use parent voltage from the supply when  bypassed Jon Hunter <jonathanh@nvidia.com> - 2016-03-31 16:30 +0200
    Re: [PATCH] regulator: core: Use parent voltage from the supply when  bypassed Mark Brown <broonie@kernel.org> - 2016-03-31 20:00 +0200
      Re: [PATCH] regulator: core: Use parent voltage from the supply when  bypassed Thierry Reding <thierry.reding@gmail.com> - 2016-04-01 19:00 +0200

csiph-web