Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1368503

Re: [PATCH v2] spi: rockchip: fix warning of static check

Show all headers | View raw

Shawn,

On Wed, Mar 30, 2016 at 8:11 PM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> Use dma_request_chan instead of dma_request_slave_channel,
> in this case we can check EPROBE_DEFER without static
> warning.

Technically this is more than just a warning fix.  The previous commit
61cadcf46cfd ("spi: rockchip: check requesting dma channel with
EPROBE_DEFER") could never have done what it was supposed to do
because dma_request_slave_channel() could never return EPROBE_DEFER.
...so really this makes the previous commit work properly.


> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Doug Anderson <dianders@chromium.org>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> ---
>
> Changes in v2:
> - use dma_request_chan and replace IS_ERR_OR_NULL()
>   with IS_ERR
> - do the same for rx
>
>  drivers/spi/spi-rockchip.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] spi: rockchip: fix warning of static check Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-31 05:20 +0200
  Re: [PATCH v2] spi: rockchip: fix warning of static check Doug Anderson <dianders@chromium.org> - 2016-03-31 20:00 +0200

csiph-web