Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1368378

Re: [PATCH 1/1] perf tools: fix format max value calculation

Show all headers | View raw

Em Wed, Mar 30, 2016 at 12:16:15PM -0700, kan.liang@intel.com escreveu:
> From: Kan Liang <kan.liang@intel.com>
> 
> Currently the max value of format is calculated by the bits number. It
> relies on the continuity of the format.
> However, uncore event format is not continuous. E.g. uncore qpi event
> format can be 0-7,21.
> If bit 21 is set, there is parsing issues as below.
> perf stat -a -e uncore_qpi_0/event=0x200002,umask=0x8/
> event syntax error: '..pi_0/event=0x200002,umask=0x8/'
>                                   \___ value too big for format, maximum
> is 511
> 
> This patch return the real max value by setting all possible bit to 1.

Looks good, applied.

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] perf tools: fix format max value calculation kan.liang@intel.com - 2016-03-31 04:50 +0200
  Re: [PATCH 1/1] perf tools: fix format max value calculation Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-31 17:00 +0200

csiph-web