Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1368327

RE: [PATCH V2 1/1] perf/core: don't find side-band event from all pmus

Show all headers | View raw

> > +static void perf_event_sb_mask(unsigned int sb_mask,
> > +			       perf_event_aux_output_cb output,
> > +			       void *data)
> > +{
> > +	int sb;
> > +
> > +	for (sb = 0; sb < sb_nr; sb++) {
> > +		if (!(sb_mask & (1 << sb)))
> > +			continue;
> > +		perf_event_sb_iterate(sb, output, data);
> > +	}
> > +}
> 
> > @@ -5852,7 +5910,8 @@ static void perf_event_task(struct task_struct
> > *task,
> >
> >  	perf_event_aux(perf_event_task_output,
> >  		       &task_event,
> > -		       task_ctx);
> > +		       task_ctx,
> > +		       (1 << sb_task) | (1 << sb_mmap) | (1 << sb_comm));
> >  }
> 
> So one side-effect of this change is that the above event can be delivered
> 3 times if you're 'lucky'.
> 
> Acme; does userspace care?

Hi Arnaldo,

Do you think if it's an issue for userspace?

Thanks,
Kan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 1/1] perf/core: don't find side-band event from all pmus  kan.liang@intel.com - 2016-03-24 03:00 +0100
  Re: [PATCH V2 1/1] perf/core: don't find side-band event from all  pmus Peter Zijlstra <peterz@infradead.org> - 2016-03-29 14:10 +0200
    RE: [PATCH V2 1/1] perf/core: don't find side-band event from all  pmus "Liang, Kan" <kan.liang@intel.com> - 2016-03-31 16:10 +0200
      Re: [PATCH V2 1/1] perf/core: don't find side-band event from all  pmus "acme@kernel.org" <acme@kernel.org> - 2016-03-31 16:30 +0200
    Re: [PATCH V2 1/1] perf/core: don't find side-band event from all  pmus Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-31 16:50 +0200
      Re: [PATCH V2 1/1] perf/core: don't find side-band event from all  pmus Peter Zijlstra <peterz@infradead.org> - 2016-03-31 17:00 +0200
        Re: [PATCH V2 1/1] perf/core: don't find side-band event from all  pmus Peter Zijlstra <peterz@infradead.org> - 2016-03-31 18:30 +0200
          Re: [PATCH V2 1/1] perf/core: don't find side-band event from all  pmus Peter Zijlstra <peterz@infradead.org> - 2016-03-31 18:30 +0200

csiph-web