Re: [PATCH 1/4] tty: vt, remove reduntant check

From	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] tty: vt, remove reduntant check
Date	2016-03-31 16:30 +0200
Message-ID	<riLLI-6lZ-9@gated-at.bofh.it> (permalink)
References	<riFPY-20X-9@gated-at.bofh.it>
Organization	Intel Corporation

Show all headers | View raw

On Thu, 31 Mar 2016 10:08:14 +0200
Jiri Slaby <jslaby@suse.cz> wrote:

> MAX_NR_CONSOLES and MAX_NR_USER_CONSOLES are both 63 since they were
> introduced in 1.1.54. And since vc_allocate does:
> 
> if (currcons >= MAX_NR_CONSOLES)
> 	return -ENXIO;
> 
> if (!vc_cons[currcons].d) {
> 	if (currcons >= MAX_NR_USER_CONSOLES && !capable(CAP_SYS_RESOURCE))
> 		return -EPERM;
> }
> 
> the second check is pointless. Remove both the check and the macro
> MAX_NR_USER_CONSOLES.

NAK

There are embedded people who do change these values.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] tty: vt, remove reduntant check Jiri Slaby <jslaby@suse.cz> - 2016-03-31 10:20 +0200
  Re: [PATCH 1/4] tty: vt, remove reduntant check One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-03-31 16:30 +0200
  Re: [PATCH 1/4] tty: vt, remove reduntant check One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-03-31 16:30 +0200

csiph-web