Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver

From	Sylwester Nawrocki <s.nawrocki@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver
Date	2016-03-31 15:00 +0200
Message-ID	<riKmC-5a4-15@gated-at.bofh.it> (permalink)
References	<riGM2-2Es-5@gated-at.bofh.it> <riGVI-2I1-27@gated-at.bofh.it> <riJJU-4OT-15@gated-at.bofh.it> <riJTz-4Vs-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/31/2016 02:28 PM, Chanwoo Choi wrote:
>> > You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions
>> > of which the return value is being tested return only ERR_PTR() values.
>> > IS_ERR_OR_NULL() suggest NULL values are possible and then constructs
>> > like
>> >         if (IS_ERR_OR_NULL(result))
>> >                 return PTR_ERR(result);
>> >
>> > are not correct anyway.
>
> OK. I'll use IS_ERR() instead of IS_ERR_OR_NULL()

Thanks, I forgot to mention there is similar issue in patches
5/20 and 6/20.

--
Regards
Sylwester

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus  frequency driver Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-31 11:20 +0200
  Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus  frequency driver Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-03-31 14:20 +0200
    Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus  frequency driver Chanwoo Choi <cwchoi00@gmail.com> - 2016-03-31 14:30 +0200
      Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus  frequency driver Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-03-31 15:00 +0200

csiph-web