Re: [PATCH] tpm: cleanup tpm_tis_remove()

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tpm: cleanup tpm_tis_remove()
Date	2016-03-31 12:40 +0200
Message-ID	<riIb8-3Af-29@gated-at.bofh.it> (permalink)
References	<riHRM-3pE-15@gated-at.bofh.it> <riHRM-3pE-23@gated-at.bofh.it> <riHRM-3pE-21@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Thu, Mar 31, 2016 at 01:17:13PM +0300, Jarkko Sakkinen wrote:
> On Thu, Mar 31, 2016 at 01:15:36PM +0300, Jarkko Sakkinen wrote:
> > Christophe,
> > 
> > On Thu, Mar 31, 2016 at 01:11:27PM +0300, Jarkko Sakkinen wrote:
> > > Created a local variable for the register in order to clean up
> > > experession where TPM_GLOBAL_INT_ENABLE is cleared. This expression is
> > > horrible to read and makes changing the function uncomfortable because
> > > like easily surpass 80 characters.
> > 
> > Can you test this patch your hardware and reply with Tested-by tag if it
> > does? I can then update your iobase patch to apply on top of this.
> > 
> > I thought it was better idea to simplify the expression a little bit
> > than make it even worse mess.
> 
> And yes  I'll fix all the typos in the commit msg in this patch before
> applying it :)

I committed this to my master branch with the option to drop if there it
does not get reviewed/tested-by's (which I doubt). Since this touches
multiple patches (locality patch too) and in addition there was couple
glitches maybe it would be good if you would prepare one more round of
the series if you don't mind?

/Jarkko

Thread

[PATCH] tpm: cleanup tpm_tis_remove() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-31 12:20 +0200
  Re: [PATCH] tpm: cleanup tpm_tis_remove() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-31 12:20 +0200
    RE: [PATCH] tpm: cleanup tpm_tis_remove() Christophe Henri RICARD <christophe-h.ricard@st.com> - 2016-03-31 12:40 +0200
    Re: [PATCH] tpm: cleanup tpm_tis_remove() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-31 12:40 +0200
      RE: [PATCH] tpm: cleanup tpm_tis_remove() Christophe Henri RICARD <christophe-h.ricard@st.com> - 2016-03-31 17:00 +0200
        Re: [PATCH] tpm: cleanup tpm_tis_remove() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-31 18:30 +0200
  Re: [PATCH] tpm: cleanup tpm_tis_remove() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-31 12:20 +0200

csiph-web