Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore
Date	2016-03-31 11:40 +0200
Message-ID	<riHf4-2VE-27@gated-at.bofh.it> (permalink)
References	<r7vAD-38v-21@gated-at.bofh.it> <riovM-64K-1@gated-at.bofh.it> <riGCn-2kC-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Michal Hocko <mhocko@kernel.org> wrote:

> On Wed 30-03-16 15:32:17, Peter Zijlstra wrote:
> > On Mon, Feb 29, 2016 at 01:58:14PM +0100, Michal Hocko wrote:
> > > I have tested on x86 with OOM situations with high mmap_sem contention
> > > (basically many parallel page faults racing with many parallel mmap/munmap
> > > tight loops) so the waiters for the write locks are routinely interrupted
> > > by SIGKILL.
> > 
> > Aside from the one niggle (as per the other email) they look good to me
> > and I would take them through the tip/locking tree.
> 
> Thanks for the review! I understand that tip/locking would be the most 
> appropriate place [...]

Yes.

> [...] but I am wondering whether this causes some issues with the follow up 
> patches which use this new API and which I expect to go via Andrew's tree.

So AFAIK Andrew's tree is based on top of linux-next, so once it goes into 
tip:locking/core, -mm can pick it up as well 1-2 days later.

Please send the changes in isolation, for merge into the locking tree.

Thanks,

	Ingo

Thread

Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Peter Zijlstra <peterz@infradead.org> - 2016-03-30 15:40 +0200
  Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Michal Hocko <mhocko@kernel.org> - 2016-03-31 11:00 +0200
    Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Ingo Molnar <mingo@kernel.org> - 2016-03-31 11:40 +0200
      Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Michal Hocko <mhocko@kernel.org> - 2016-03-31 13:00 +0200
      Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Andrew Morton <akpm@linux-foundation.org> - 2016-03-31 19:10 +0200
        Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Ingo Molnar <mingo@kernel.org> - 2016-04-01 08:40 +0200
          Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Michal Hocko <mhocko@kernel.org> - 2016-04-01 11:30 +0200
            Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Ingo Molnar <mingo@kernel.org> - 2016-04-01 12:00 +0200
              Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Michal Hocko <mhocko@kernel.org> - 2016-04-01 13:00 +0200
        Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Michal Hocko <mhocko@kernel.org> - 2016-04-01 09:30 +0200
          Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore Andrew Morton <akpm@linux-foundation.org> - 2016-04-01 11:20 +0200

csiph-web