Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1367855
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] tpm: remove redundant code from self-test functions |
| Date | 2016-03-31 08:40 +0200 |
| Message-ID | <riEqT-P8-29@gated-at.bofh.it> (permalink) |
| References | <riom6-60u-3@gated-at.bofh.it> <riDEu-cW-3@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Wed, Mar 30, 2016 at 11:46:23PM -0600, Jason Gunthorpe wrote:
> On Wed, Mar 30, 2016 at 04:20:45PM +0300, Jarkko Sakkinen wrote:
>
> > - rc = be32_to_cpu(cmd.header.out.return_code);
> > if (rc == TPM_ERR_DISABLED || rc == TPM_ERR_DEACTIVATED) {
>
> This line is the entire reason it is open coded, I see it being
> removed, but I don't see how the functionality is maintained?
When tpm_trance_cmd() returns a positive number it is the TPM error code
that it returns. tpm_pcr_read() does pass through whatever
tpm_trace_cmd() returns so the above condition should still work as
expected.
> Jason
/Jarkko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] tpm: remove redundant code from self-test functions Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-30 15:30 +0200
Re: [PATCH] tpm: remove redundant code from self-test functions Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-30 15:30 +0200
Re: [PATCH] tpm: remove redundant code from self-test functions Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-03-31 07:50 +0200
Re: [PATCH] tpm: remove redundant code from self-test functions Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-03-31 08:40 +0200
Re: [PATCH] tpm: remove redundant code from self-test functions Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-04-02 05:20 +0200
csiph-web