Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework
Date	2016-03-31 08:30 +0200
Message-ID	<riEhc-JS-3@gated-at.bofh.it> (permalink)
References	<rdi7E-8pT-3@gated-at.bofh.it> <rdi7F-8pT-23@gated-at.bofh.it> <riloe-3NH-15@gated-at.bofh.it> <rispJ-nD-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Mark Brown <broonie@kernel.org> writes:
> [ text/plain ]
> On Wed, Mar 30, 2016 at 01:09:00PM +0300, Felipe Balbi wrote:
>> Baolin Wang <baolin.wang@linaro.org> writes:
>
>> > +#include <linux/of.h>
>> > +#include <linux/of_device.h>
>> > +#include <linux/of_address.h>
>> > +#include <linux/platform_device.h>
>
>> not very nice to depend on either of or platform_device here. What about
>> PCI-based devices ?
>
> The header inclusion shouldn't be conditional though.  But looking at
> the patch I can't immediately see any use of these in the code anyway.

fair enough, seems like removal is the way.

>> > +static DEVICE_ATTR_RW(sdp_limit);
>
>> why RW ? Who's going to use these ? Also, you're not documenting this
>> new sysfs file.
>
> If they end up not writeable should we just remove them entirely since
> they should just be the spec values?

if they are really just spec values, why would even let them be modified
to start with ? ;-)

But yeah, seems like this is not interesting to userland.

-- 
balbi

Thread

Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-03-30 12:20 +0200
  Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Mark Brown <broonie@kernel.org> - 2016-03-30 19:50 +0200
    Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-03-31 08:30 +0200
  Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-03-31 08:30 +0200
    Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-03-31 08:50 +0200
      Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-03-31 10:10 +0200
        Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-03-31 10:30 +0200
          Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-03-31 10:40 +0200
            Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-03-31 12:10 +0200
              Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-03-31 13:20 +0200
      Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Mark Brown <broonie@kernel.org> - 2016-03-31 19:10 +0200
        Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Felipe Balbi <balbi@kernel.org> - 2016-04-01 07:50 +0200
          Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework Mark Brown <broonie@kernel.org> - 2016-04-01 16:20 +0200

csiph-web