Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1366464

Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity

From Tim Harvey <tharvey@gateworks.com>
Newsgroups linux.kernel
Subject Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity
Date 2016-03-29 18:50 +0200
Message-ID <ri506-wp-11@gated-at.bofh.it> (permalink)
References (1 earlier) <ri2lB-72M-31@gated-at.bofh.it> <ri2OC-7x2-37@gated-at.bofh.it> <ri3hF-7IL-25@gated-at.bofh.it> <ri3AZ-86I-3@gated-at.bofh.it> <ri4GL-pQ-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 29, 2016 at 9:13 AM, Roberto Fichera <kernel@tekno-soft.it> wrote:
> On 03/29/2016 05:10 PM, Tim Harvey wrote:
>> Arnd,
>>
>> Right, on the IMX the MSI interrupt is GIC-120 which is also the
>> legacy INTD and I do see that if I happen to put a radio in a slot
>> where due to swizzling its pin1 becomes INTD (GIC-120) the interrupt
>> does fire and the device works. Any other slot using GIC-123 (INTA),
>> GIC-122 (INTB), or GIC-121 (INTC) never fires so its very possible
>> that something in the designware core is masking out the legacy irqs.
>> I would also think this was something IMX specific, but I really don't
>> see any codepaths in pci-imx6.c that would cause that: a driver
>> requesting a legacy PCI would get a GIC interrupt which is handled by
>> the IMX6 gpc interrupt controller.
>>
>> Any dra7xxx, exynos, spear13xx, keystone, layerscape, hisi, qcom SoC
>> users of designware PCIe core out there that can verify PCI MSI and
>> legacy are both working at the same time?
>>
>> Lucas is the expert here and I believe he has the documentation for
>> the designware core that Freescale doens't provide with the IMX6
>> documentation so hopefully he can provide some insight. He's the one
>> that has authored all the MSI support and has been using it.
>>
>> I typically advise our users to 'not' enable MSI because
>> architecturally you can spread 4 distinct legacy irq's across CPU's
>> better than a single shared irq.
>
> Don't know if I'm facing similar problem, however devices connected in miniPCI slot behind
> a PCIe-to-PCI bridge (MSI is disabled) using INTA all is working ok, including shared IRQ.
> In case of INTB will not work, and the GIC irq quite often get stuck.
>

Roberto,

What board/platform is this and what does /proc/interrupts look like?

This sounds like what would happen if the downstream interrupts on the
PCIe-to-PCI bridge are not mapped properly as was the case with a
board I support (in which case I had to work out a bootloader fixup
that placed a non-standard interrupt-map in the device-tree for the
bridge). What bridge are you using?

Tim

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity khalasa@piap.pl (Krzysztof Hałasa) - 2016-03-25 14:40 +0100
  Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Fabio Estevam <festevam@gmail.com> - 2016-03-27 16:50 +0200
    Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Fabio Estevam <festevam@gmail.com> - 2016-03-28 02:30 +0200
      Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-28 22:00 +0200
        Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Fabio Estevam <festevam@gmail.com> - 2016-03-28 22:20 +0200
          Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-28 22:50 +0200
            Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Fabio Estevam <festevam@gmail.com> - 2016-03-28 23:40 +0200
              Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-29 00:10 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Fabio Estevam <festevam@gmail.com> - 2016-03-29 00:20 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity khalasa@piap.pl (Krzysztof Hałasa) - 2016-03-29 07:50 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity khalasa@piap.pl (Krzysztof Hałasa) - 2016-03-29 07:50 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity khalasa@piap.pl (Krzysztof Hałasa) - 2016-03-29 07:30 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Lucas Stach <l.stach@pengutronix.de> - 2016-03-29 11:00 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity khalasa@piap.pl (Krzysztof Hałasa) - 2016-03-29 12:40 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Lucas Stach <l.stach@pengutronix.de> - 2016-03-29 13:00 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Arnd Bergmann <arnd@arndb.de> - 2016-03-29 15:20 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-29 15:40 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Arnd Bergmann <arnd@arndb.de> - 2016-03-29 16:00 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-29 16:30 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Arnd Bergmann <arnd@arndb.de> - 2016-03-29 17:00 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-29 17:20 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Arnd Bergmann <arnd@arndb.de> - 2016-03-29 17:30 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-29 19:50 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Arnd Bergmann <arnd@arndb.de> - 2016-03-29 21:50 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Marc Zyngier <marc.zyngier@arm.com> - 2016-03-29 20:00 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Roberto Fichera <kernel@tekno-soft.it> - 2016-03-29 18:30 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Roberto Fichera <kernel@tekno-soft.it> - 2016-03-29 18:50 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-29 19:40 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Roberto Fichera <kernel@tekno-soft.it> - 2016-03-30 10:10 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Arnd Bergmann <arnd@arndb.de> - 2016-03-30 12:20 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Roberto Fichera <kernel@tekno-soft.it> - 2016-03-30 15:00 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-30 15:40 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Roberto Fichera <kernel@tekno-soft.it> - 2016-03-30 17:30 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-29 18:50 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity khalasa@piap.pl (Krzysztof Hałasa) - 2016-03-30 10:20 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Tim Harvey <tharvey@gateworks.com> - 2016-03-31 18:20 +0200
                Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Fabio Estevam <festevam@gmail.com> - 2016-03-29 16:20 +0200
            Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity khalasa@piap.pl (Krzysztof Hałasa) - 2016-03-29 07:30 +0200
  Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset()  polarity Petr Štetiar <ynezz@true.cz> - 2016-03-30 14:20 +0200
    Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Fabio Estevam <festevam@gmail.com> - 2016-03-30 14:50 +0200
    Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Marcel Ziswiler <marcel.ziswiler@toradex.com> - 2016-03-30 18:20 +0200

csiph-web