Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365253

Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock

From Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock
Date 2016-03-28 02:50 +0200
Message-ID <rhtxv-7NP-3@gated-at.bofh.it> (permalink)
References <rcRKa-7pG-5@gated-at.bofh.it> <rcRKb-7pG-25@gated-at.bofh.it> <rgnaN-1wQ-5@gated-at.bofh.it> <rgwH8-8d1-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Sylwester,

On 2016년 03월 25일 18:50, Sylwester Nawrocki wrote:
> Hi Chanwoo,
> 
> On 03/25/2016 12:39 AM, Chanwoo Choi wrote:
>> diff --git a/include/dt-bindings/clock/exynos3250.h 
>> b/include/dt-bindings/clock/exynos3250.h
>>> index ddb874130d86..c796ff02ceeb 100644
>>> --- a/include/dt-bindings/clock/exynos3250.h
>>> +++ b/include/dt-bindings/clock/exynos3250.h
> ...
>>> -#define CLK_NR_CLKS			249
>>> +#define CLK_NR_CLKS			250
> 
> What do you think about putting all the changes to include/dt-bindings/
> clock/exynos3250.h into a separate patch? Now in patch 3/8 there
> is being changed again what was added in patch 2/8. However, my main
> point is to have a minimum required in a common topic branch for the clk
> and the arm-soc trees, so there is no need for arm-soc to pull all
> the drives/clk changes.
> It might not be that sensible in case of just those 2 patches in your
> series, nevertheless it would be good to keep that in mind for future
> submissions.

You mean that separate patch1 include only the new clock id about both UART2 and MMC2
and the patch2/patch3 just use the new clock id as following:

patch1 dt-bindings: Add the clock id of UART2 and MMC2 for Exynos3250
patch2 clk: samsung: exynos3250: Add UART2 clock
patch3 clk: samsung: exynos3250: Add MMC2 clock

As far as I understand it is that right?
If it is ok, I'll modify it on v4 patchset as you comment.

Best Regards,
Chanwoo Choi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-25 00:50 +0100
  Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-03-25 11:00 +0100
    Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock Chanwoo Choi <cw00.choi@samsung.com> - 2016-03-28 02:50 +0200
      Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-29 03:50 +0200
        Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-03-30 11:40 +0200
        Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-03-31 13:10 +0200
          Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-01 02:20 +0200
      Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-03-30 11:40 +0200

csiph-web