Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end

From	"Wangnan (F)" <wangnan0@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end
Date	2016-03-28 03:10 +0200
Message-ID	<rhtQR-8aU-1@gated-at.bofh.it> (permalink)
References	(3 earlier) <rgz2i-1z4-19@gated-at.bofh.it> <rgzbX-1Ed-1@gated-at.bofh.it> <rgAKJ-2QC-3@gated-at.bofh.it> <rhkNz-1SE-3@gated-at.bofh.it> <rhkXg-1Xu-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2016/3/27 23:30, pi3orama wrote:
>
> 发自我的 iPhone
>
>> 在 2016年3月27日，下午11:20，Peter Zijlstra <peterz@infradead.org> 写道：
>>
>> On Fri, Mar 25, 2016 at 10:14:36PM +0800, Wangnan (F) wrote:
>>>>> I think you enabled some unusual config options?
>> x86_64-defconfig
>>
>>>> You must enabled CONFIG_OPTIMIZE_INLINING. Now I get similar result:
>> It has that indeed.
>>
>>> After enabling CONFIG_OPTIMIZE_INLINING:
>>>
>>> Test its performance by calling 'close(-1)' for 3000000 times and
>>> use 'perf record -o /dev/null -e raw_syscalls:* test-ring-buffer' to
>>> capture system calls:
>>>
>>>                   MEAN         STDVAR
>>> BASE            800077.1     23448.13
>>> RAWPERF.PRE    2465858.0    603473.70
>>> RAWPERF.POST   2471925.0    609437.60
>>>
>>> Considering the high stdvar, after applying this patch the performance
>>> is not change.
>> Why is your variance so immense? And doesn't that render the
>> measurements pointless?
>>
> For some unknown reason, about
> 10% of these results raises 2 times of normal
> results. Say, "normal results" are about
> 2200000, but those "outliers" are about
> 4400000 (I can't access raw data now).
> Variance becomes much smaller if I remove
> those outliers.

After manually removing outliners (remove 10 outliners from 100 raw
data points in each data set):


                  MEAN         STDVAR
BASE            800077.1     23448.13
RAWPERF.PRE    2265741.0     10421.35
RAWPERF.POST   2269826.0     10507.45

Thank you.

> I guess the outliers is caused by some type
> of lock stepping? No clue about it.
>
> Thank you.
>

Thread

Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end Peter Zijlstra <peterz@infradead.org> - 2016-03-23 11:00 +0100
  Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end "Wangnan (F)" <wangnan0@huawei.com> - 2016-03-23 11:10 +0100
    Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-03-23 20:30 +0100
      Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end "Wangnan (F)" <wangnan0@huawei.com> - 2016-03-24 05:00 +0100
        Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-03-24 18:40 +0100
  Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end "Wangnan (F)" <wangnan0@huawei.com> - 2016-03-25 13:30 +0100
    Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end "Wangnan (F)" <wangnan0@huawei.com> - 2016-03-25 13:40 +0100
      Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end "Wangnan (F)" <wangnan0@huawei.com> - 2016-03-25 15:20 +0100
        Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end Peter Zijlstra <peterz@infradead.org> - 2016-03-27 17:30 +0200
          Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end pi3orama <pi3orama@163.com> - 2016-03-27 17:40 +0200
            Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end "Wangnan (F)" <wangnan0@huawei.com> - 2016-03-28 03:10 +0200
              Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end "Wangnan (F)" <wangnan0@huawei.com> - 2016-03-28 04:10 +0200
                Re: [PATCH 3/5] perf core: Prepare writing into ring buffer from end "Wangnan (F)" <wangnan0@huawei.com> - 2016-03-28 05:00 +0200

csiph-web