Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1365099

Re: [PATCH] perf config: Tidy up the code setting buildid dir

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] perf config: Tidy up the code setting buildid dir
Date 2016-03-27 13:20 +0200
Message-ID <rhgTE-7rL-7@gated-at.bofh.it> (permalink)
References <rg8bM-7NQ-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Mar 24, 2016 at 04:49:33PM +0900, Taeung Song wrote:
> Add new perf_buildid_config() into perf_default_config,
> bring set_buildid_dir() next to perf_default_config,
> rename some variable name as more readable name and etc
> in order to clean up code about buildid dir.
> 
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Wang Nan <wangnan0@huawei.com>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
>  tools/perf/perf.c        |  3 +--
>  tools/perf/util/config.c | 57 +++++++++++++++++++-----------------------------
>  2 files changed, 23 insertions(+), 37 deletions(-)

though it's failry simple change we try to separate changes

seems like 3 independent changes:

  - perf.c hunk change
  - buildid_dir_command_config/perf_buildid_config rework
  - set_buildid_dir fix

thanks,
jirka

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] perf config: Tidy up the code setting buildid dir Taeung Song <treeze.taeung@gmail.com> - 2016-03-24 08:50 +0100
  Re: [PATCH] perf config: Tidy up the code setting buildid dir Jiri Olsa <jolsa@redhat.com> - 2016-03-27 13:20 +0200
    Re: [PATCH] perf config: Tidy up the code setting buildid dir Taeung Song <treeze.taeung@gmail.com> - 2016-03-27 17:50 +0200

csiph-web