Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1366124

[PATCH V9 RESEND 03/14] thermal: tegra: get rid of PDIV/HOTSPOT hack

From Wei Ni <wni@nvidia.com>
Newsgroups linux.kernel
Subject [PATCH V9 RESEND 03/14] thermal: tegra: get rid of PDIV/HOTSPOT hack
Date 2016-03-29 12:40 +0200
Message-ID <rhZe2-4MC-21@gated-at.bofh.it> (permalink)
References <rhZ4m-4HB-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Get rid of T124-specific PDIV/HOTSPOT hack.
tegra-soctherm.c contained a hack to set the SENSOR_PDIV and
SENSOR_HOTSPOT_OFFSET registers - it just did two writes of
T124-specific opaque values.  Convert these into a form that can be
substituted on a per-chip basis, and into structure fields that have
at least some independent meaning.

Signed-off-by: Wei Ni <wni@nvidia.com>
---
 drivers/thermal/tegra/tegra-soctherm.c | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/drivers/thermal/tegra/tegra-soctherm.c b/drivers/thermal/tegra/tegra-soctherm.c
index 7c1f41c0733a..e486d034adb4 100644
--- a/drivers/thermal/tegra/tegra-soctherm.c
+++ b/drivers/thermal/tegra/tegra-soctherm.c
@@ -48,14 +48,12 @@
 #define SENSOR_CONFIG2_THERMB_SHIFT		0
 
 #define SENSOR_PDIV				0x1c0
-#define SENSOR_PDIV_T124			0x8888
 #define SENSOR_PDIV_CPU_MASK			(0xf << 12)
 #define SENSOR_PDIV_GPU_MASK			(0xf << 8)
 #define SENSOR_PDIV_MEM_MASK			(0xf << 4)
 #define SENSOR_PDIV_PLLX_MASK			(0xf << 0)
 
 #define SENSOR_HOTSPOT_OFF			0x1c4
-#define SENSOR_HOTSPOT_OFF_T124			0x00060600
 #define SENSOR_HOTSPOT_CPU_MASK			(0xff << 16)
 #define SENSOR_HOTSPOT_GPU_MASK			(0xff << 8)
 #define SENSOR_HOTSPOT_MEM_MASK			(0xff << 0)
@@ -436,6 +434,7 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 	struct resource *res;
 	unsigned int i;
 	int err;
+	u32 pdiv, hotspot;
 
 	const struct tegra_tsensor *tsensors = t124_tsensors;
 	const struct tegra_tsensor_group **ttgs = tegra124_tsensor_groups;
@@ -493,8 +492,20 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
 			goto disable_clocks;
 	}
 
-	writel(SENSOR_PDIV_T124, tegra->regs + SENSOR_PDIV);
-	writel(SENSOR_HOTSPOT_OFF_T124, tegra->regs + SENSOR_HOTSPOT_OFF);
+	/* Program pdiv and hotspot offsets per THERM */
+	pdiv = readl(tegra->regs + SENSOR_PDIV);
+	hotspot = readl(tegra->regs + SENSOR_HOTSPOT_OFF);
+	for (i = 0; i < TEGRA124_SOCTHERM_SENSOR_NUM; ++i) {
+		pdiv = REG_SET_MASK(pdiv, ttgs[i]->pdiv_mask,
+				    ttgs[i]->pdiv);
+		/* hotspot offset from PLLX, doesn't need to configure PLLX */
+		if (ttgs[i]->id != TEGRA124_SOCTHERM_SENSOR_PLLX)
+			hotspot =  REG_SET_MASK(hotspot,
+						ttgs[i]->pllx_hotspot_mask,
+						ttgs[i]->pllx_hotspot_diff);
+	}
+	writel(pdiv, tegra->regs + SENSOR_PDIV);
+	writel(hotspot, tegra->regs + SENSOR_HOTSPOT_OFF);
 
 	/* Initialize thermctl sensors */
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V9 RESEND 00/14] Add T210 support in Tegra soctherm Wei Ni <wni@nvidia.com> - 2016-03-29 12:30 +0200
  [PATCH V9 RESEND 06/14] thermal: tegra: add a debugfs to show registers Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  Re: [PATCH V9 RESEND 00/14] Add T210 support in Tegra soctherm Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
    Re: [PATCH V9 RESEND 00/14] Add T210 support in Tegra soctherm Eduardo Valentin <edubezval@gmail.com> - 2016-03-29 17:20 +0200
  [PATCH V9 RESEND 03/14] thermal: tegra: get rid of PDIV/HOTSPOT hack Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  [PATCH V9 RESEND 13/14] arm64: tegra: add soctherm node for Tegra210 Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
    Re: [PATCH V9 RESEND 13/14] arm64: tegra: add soctherm node for  Tegra210 Eduardo Valentin <edubezval@gmail.com> - 2016-03-29 17:20 +0200
      Re: [PATCH V9 RESEND 13/14] arm64: tegra: add soctherm node for Tegra210 Wei Ni <wni@nvidia.com> - 2016-03-30 05:30 +0200
        Re: [PATCH V9 RESEND 13/14] arm64: tegra: add soctherm node for Tegra210 Wei Ni <wni@nvidia.com> - 2016-03-30 12:30 +0200
      Re: [PATCH V9 RESEND 13/14] arm64: tegra: add soctherm node for Tegra210 Wei Ni <wni@nvidia.com> - 2016-04-01 09:10 +0200
  [PATCH V9 RESEND 02/14] thermal: tegra: combine sensor group-related data Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  [PATCH V9 RESEND 11/14] thermal: tegra: handle HW initialization in one funcotion Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  [PATCH V9 RESEND 07/14] thermal: of-thermal: allow setting trip_temp on hardware Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  [PATCH V9 RESEND 01/14] thermal: tegra: move tegra thermal files into tegra directory Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  [PATCH V9 RESEND 05/14] thermal: tegra: add Tegra210 specific SOC_THERM driver Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  [PATCH V9 RESEND 09/14] thermal: tegra: add thermtrip function Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  [PATCH V9 RESEND 10/14] thermal: tegra: handle clocks in one function Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  [PATCH V9 RESEND 14/14] arm: tegra: set critical trips for Tegra124 Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
    Re: [PATCH V9 RESEND 14/14] arm: tegra: set critical trips for  Tegra124 Eduardo Valentin <edubezval@gmail.com> - 2016-03-29 17:20 +0200
      Re: [PATCH V9 RESEND 14/14] arm: tegra: set critical trips for Tegra124 Wei Ni <wni@nvidia.com> - 2016-04-01 09:10 +0200
    Re: [PATCH V9 RESEND 14/14] arm: tegra: set critical trips for Tegra124 Wei Ni <wni@nvidia.com> - 2016-03-30 12:40 +0200
  [PATCH V9 RESEND 12/14] thermal: tegra: add PM support Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  [PATCH V9 RESEND 08/14] of: add notes of critical trips for soctherm Wei Ni <wni@nvidia.com> - 2016-03-29 12:40 +0200
  Re: [PATCH V9 RESEND 00/14] Add T210 support in Tegra soctherm Eduardo Valentin <edubezval@gmail.com> - 2016-03-29 17:20 +0200

csiph-web