Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1365987
| From | "Zheng, Lv" <lv.zheng@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH 24/30] ACPICA: Hardware: Add access_width/bit_offset support in acpi_hw_read() |
| Date | 2016-03-29 10:20 +0200 |
| Message-ID | <rhX2x-3h3-13@gated-at.bofh.it> (permalink) |
| References | <rg2pH-3zI-3@gated-at.bofh.it> <rg2zp-3Dt-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi, Rafael
PATCH 24 and 25 are reported to have issues around mask generation:
https://bugs.acpica.org/show_bug.cgi?id=1270
Please drop them.
I'll re-send the 2 patches after the fix solution is determined.
Thanks in advance.
Best regards
-Lv
> From: Zheng, Lv
> Subject: [PATCH 24/30] ACPICA: Hardware: Add access_width/bit_offset
> support in acpi_hw_read()
>
> ACPICA commit 96ece052d4d073aae4f935f0ff0746646aea1174
> ACPICA commit 3d8583a054e410f2ea4d73b48986facad9cfc0d4
>
> This patch adds access_width/bit_offset support in acpi_hw_read().
> This also enables GAS definition where bit_width is not a power of
> two. Lv Zheng.
>
> Link: https://github.com/acpica/acpica/commit/96ece052
> Link: https://github.com/acpica/acpica/commit/3d8583a0
> Link: https://bugs.acpica.org/show_bug.cgi?id=1240
> Signed-off-by: Lv Zheng <lv.zheng@intel.com>
> Signed-off-by: Bob Moore <robert.moore@intel.com>
> ---
> drivers/acpi/acpica/hwregs.c | 66 +++++++++++++++++++++++++++++++++---
> ------
> 1 file changed, 53 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/acpi/acpica/hwregs.c b/drivers/acpi/acpica/hwregs.c
> index bc3f60a..12fed0c 100644
> --- a/drivers/acpi/acpica/hwregs.c
> +++ b/drivers/acpi/acpica/hwregs.c
> @@ -150,17 +150,19 @@ acpi_hw_validate_register(struct
> acpi_generic_address *reg,
> * 64-bit values is not needed.
> *
> * LIMITATIONS: <These limitations also apply to acpi_hw_write>
> - * bit_width must be exactly 8, 16, or 32.
> * space_ID must be system_memory or system_IO.
> - * bit_offset and access_width are currently ignored, as there has
> - * not been a need to implement these.
> *
>
> ****************************************************************
> **************/
>
> acpi_status acpi_hw_read(u32 *value, struct acpi_generic_address * reg)
> {
> u64 address;
> + u8 access_width;
> + u32 bit_width;
> + u8 bit_offset;
> u64 value64;
> + u32 value32;
> + u8 index;
> acpi_status status;
>
> ACPI_FUNCTION_NAME(hw_read);
> @@ -172,28 +174,66 @@ acpi_status acpi_hw_read(u32 *value, struct
> acpi_generic_address * reg)
> return (status);
> }
>
> - /* Initialize entire 32-bit return value to zero */
> -
> + /*
> + * Initialize entire 32-bit return value to zero, convert access_width
> + * into number of bits based
> + */
> *value = 0;
> + access_width = reg->access_width ? reg->access_width : 1;
> + access_width = 1 << (access_width + 2);
> + bit_width = reg->bit_offset + reg->bit_width;
> + bit_offset = reg->bit_offset;
>
> /*
> * Two address spaces supported: Memory or IO. PCI_Config is
> * not supported here because the GAS structure is insufficient
> */
> - if (reg->space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) {
> - status = acpi_os_read_memory((acpi_physical_address)
> - address, &value64, reg->bit_width);
> + index = 0;
> + while (bit_width) {
> + if (bit_offset > access_width) {
> + value32 = 0;
> + bit_offset -= access_width;
> + } else {
> + if (reg->space_id ==
> ACPI_ADR_SPACE_SYSTEM_MEMORY) {
> + status =
> +
> acpi_os_read_memory((acpi_physical_address)
> + address +
> + index *
> + ACPI_DIV_8
> + (access_width),
> + &value64,
> access_width);
> + value32 = (u32)value64;
> + } else { /* ACPI_ADR_SPACE_SYSTEM_IO, validated
> earlier */
> +
> + status = acpi_hw_read_port((acpi_io_address)
> + address +
> + index *
> + ACPI_DIV_8
> + (access_width),
> + &value32,
> + access_width);
> + }
> +
> + if (bit_offset) {
> + value32 &=
> ACPI_MASK_BITS_BELOW(bit_offset);
> + bit_offset = 0;
> + }
> + if (bit_width < access_width) {
> + value32 &=
> ACPI_MASK_BITS_ABOVE(bit_width);
> + }
> + }
>
> - *value = (u32)value64;
> - } else { /* ACPI_ADR_SPACE_SYSTEM_IO, validated earlier */
> + ACPI_SET_BITS(value, index * access_width,
> + (1 << access_width) - 1, value32);
>
> - status = acpi_hw_read_port((acpi_io_address)
> - address, value, reg->bit_width);
> + bit_width -=
> + bit_width > access_width ? access_width : bit_width;
> + index++;
> }
>
> ACPI_DEBUG_PRINT((ACPI_DB_IO,
> "Read: %8.8X width %2d from %8.8X%8.8X (%s)\n",
> - *value, reg->bit_width,
> ACPI_FORMAT_UINT64(address),
> + *value, access_width,
> ACPI_FORMAT_UINT64(address),
> acpi_ut_get_region_name(reg->space_id)));
>
> return (status);
> --
> 1.7.10
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/30] ACPICA: 20160318 Release Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:40 +0100
[PATCH 28/30] ACPICA: Events: Fix an issue that _REG association can happen before namespace is initialized Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 24/30] ACPICA: Hardware: Add access_width/bit_offset support in acpi_hw_read() Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
RE: [PATCH 24/30] ACPICA: Hardware: Add access_width/bit_offset support in acpi_hw_read() "Zheng, Lv" <lv.zheng@intel.com> - 2016-03-29 10:20 +0200
[PATCH 21/30] ACPICA: Utilities: Add ACPI_IS_POWER_OF_TWO() Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 26/30] ACPICA: Interpreter: Fix wrong conditions for acpi_ev_install_region_handlers() invocation Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 17/30] ACPICA: Add support for QNX 6.6 platform Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 14/30] ACPICA: iASL: Cleanup/optimization for ToPLD macro support Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 29/30] ACPICA: Namespace: Reorder \_SB._INI to make sure it is evaluated before _REG evaluations Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 30/30] ACPICA: Update version to 20160318 Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 16/30] ACPICA: Headers: Update generation of the ACPICA library Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 20/30] ACPICA: iASL/Disassembler: Improve handling of unresolved methods Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 19/30] ACPICA: All: const keyword changes across the ACPICA source Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 25/30] ACPICA: Hardware: Add access_width/bit_offset support for acpi_hw_write() Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 18/30] ACPICA: Utilities: Update for strtoul64 merger Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 13/30] ACPICA: Interpreter: Update some function headers, no functional change Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 22/30] Utilities: Fix missing parentheses in ACPI_GET_BITS()/ACPI_SET_BITS() Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 23/30] ACPICA: Hardware: Enhance acpi_hw_validate_register() with access_width/bit_offset awareness Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 15/30] ACPICA: Cleanup some invocation indentations, no functional change Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 12/30] ACPICA: Intepreter: Add object extensions to Concatenate operand Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 27/30] ACPICA: Tables: Fix wrong MLC condition for dynamic table loading Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
[PATCH 06/30] ACPICA: IORT: Add in support for the SMMUv3 subtable Lv Zheng <lv.zheng@intel.com> - 2016-03-24 02:50 +0100
Re: [PATCH 00/30] ACPICA: 20160318 Release "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-24 14:10 +0100
RE: [PATCH 00/30] ACPICA: 20160318 Release "Zheng, Lv" <lv.zheng@intel.com> - 2016-03-28 05:10 +0200
csiph-web