Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1365948
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE |
| Date | 2016-03-29 09:40 +0200 |
| Message-ID | <rhWpQ-2Nj-15@gated-at.bofh.it> (permalink) |
| References | <rfnPz-qn-7@gated-at.bofh.it> <rfnPA-qn-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Mar 22, 2016 at 02:12:28PM +0800, Ming Lei wrote: > drbd is the only user of BIO_MAX_SIZE, so use BIO_MAX_PAGES > instead. That whole code block looks completely bogus to me, although your patch doesn't make it any worse. I/O size for a network protocol shouldn't dependend on the number of vectors in a kernel internal structure. Well, getting rid of BIO_MAX_SIZE is worth it, so: Reviewed-by: Christoph Hellwig <hch@lst.de>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE Ming Lei <ming.lei@canonical.com> - 2016-03-22 07:20 +0100
Re: [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE Christoph Hellwig <hch@infradead.org> - 2016-03-29 09:40 +0200
Re: [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE Lars Ellenberg <lars.ellenberg@linbit.com> - 2016-03-29 10:20 +0200
csiph-web