Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365768

Re: [PATCH v2 3/5] dt-bindings: phy: bindings document for common Broadcom SATA3 PHY driver

Show all headers | View raw

Le 27/03/2016 21:48, Anup Patel a écrit :
>  Required properties:
>  - compatible: should be one or more of
>       "brcm,bcm7425-sata-phy"
>       "brcm,bcm7445-sata-phy"
> +     "brcm,iproc-ns2-sata-phy"
>       "brcm,phy-sata3"
>  - address-cells: should be 1
>  - size-cells: should be 0
> -- reg: register range for the PHY PCB interface
> -- reg-names: should be "phy"
> +- reg: register ranges for the PHY PCB interface
> +- reg-names: should be "phy" and "phy-ctrl"
> +     The "phy-ctrl" registers are only required for
> +     "brcm,iproc-ns2-sata-phy".

I objected to adding another register during the internal review, which,
in the case of the STB chips is dealt with at the AHCI controller level
as was requested when Brian got the driver sent, but if that is the only
point here, then let's get your patches merged as-is.

The rest of the changes look fine so:

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] Add SATA3 support for Broadcom NS2 SVK Anup Patel <anup.patel@broadcom.com> - 2016-03-28 07:00 +0200
  [PATCH v2 2/5] phy: Add support for NS2 SATA3 PHY in Broadcom SATA3 PHY driver Anup Patel <anup.patel@broadcom.com> - 2016-03-28 07:00 +0200
    Re: [PATCH v2 2/5] phy: Add support for NS2 SATA3 PHY in Broadcom  SATA3 PHY driver Florian Fainelli <f.fainelli@gmail.com> - 2016-03-29 03:40 +0200
  [PATCH v2 1/5] phy: Rename phy-brcmstb-sata driver to phy-brcm-sata driver Anup Patel <anup.patel@broadcom.com> - 2016-03-28 07:00 +0200
    Re: [PATCH v2 1/5] phy: Rename phy-brcmstb-sata driver to  phy-brcm-sata driver Florian Fainelli <f.fainelli@gmail.com> - 2016-03-29 03:30 +0200
  [PATCH v2 5/5] arm64: dts: Add SATA3 AHCI and SATA3 PHY DT nodes for NS2 Anup Patel <anup.patel@broadcom.com> - 2016-03-28 07:00 +0200
  [PATCH v2 4/5] dt-bindings: ata: add compatible string for iProc AHCI controller Anup Patel <anup.patel@broadcom.com> - 2016-03-28 07:00 +0200
    Re: [PATCH v2 4/5] dt-bindings: ata: add compatible string for iProc  AHCI controller Florian Fainelli <f.fainelli@gmail.com> - 2016-03-29 03:30 +0200
      Re: [PATCH v2 4/5] dt-bindings: ata: add compatible string for iProc  AHCI controller Tejun Heo <tj@kernel.org> - 2016-03-30 21:00 +0200
  [PATCH v2 3/5] dt-bindings: phy: bindings document for common Broadcom SATA3 PHY driver Anup Patel <anup.patel@broadcom.com> - 2016-03-28 07:00 +0200
    Re: [PATCH v2 3/5] dt-bindings: phy: bindings document for common  Broadcom SATA3 PHY driver Florian Fainelli <f.fainelli@gmail.com> - 2016-03-29 03:30 +0200

csiph-web