Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365699

Re: Build regressions/improvements in v4.6-rc1

Show all headers | View raw

On Sun, Mar 27, 2016 at 02:43:24PM +0200, Geert Uytterhoeven wrote:
> On Sun, Mar 27, 2016 at 2:39 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > Below is the list of build error/warning regressions/improvements in
> > v4.6-rc1[1] compared to v4.5[2].
> >
> > Summarized:
> >   - build errors: +9/-6
> 
> > [1] http://kisskb.ellerman.id.au/kisskb/head/10114/ (all 262 configs)
> > [2] http://kisskb.ellerman.id.au/kisskb/head/10047/ (all 262 configs)
> 
> > 9 error regressions:
> >   + /home/kisskb/slave/src/fs/xfs/xfs_ondisk.h: error: call to
> > '__compiletime_assert_79' declared with attribute error: XFS:
> > sizeof(xfs_attr_shortform_t) is wrong, expected 8:  => 79:2
> 
> cris-allyesconfig, cris-allmodconfig

Yup, cris is the only platform that throws this error on this
structure. It's an on-disk structure and relying on the gcc
optimiser to do the same thing from release to release has become
such a crap-shoot these days. Hence as a stop-gap measure we added
build time checking of what they compiler is doing with those
structures, and to refuse to build XFS if the compiler/platform is
doing something obviously different.

Modernising the on-disk structure definitions is on the list of
things to do, but it's nowhere near the top of my list at the
moment...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: Build regressions/improvements in v4.6-rc1 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-27 14:50 +0200
  Re: Build regressions/improvements in v4.6-rc1 Rich Felker <dalias@libc.org> - 2016-03-27 15:20 +0200
    Re: Build regressions/improvements in v4.6-rc1 Rich Felker <dalias@libc.org> - 2016-03-27 19:10 +0200
  Re: Build regressions/improvements in v4.6-rc1 Dave Chinner <david@fromorbit.com> - 2016-03-29 00:00 +0200
    Re: Build regressions/improvements in v4.6-rc1 "Darrick J. Wong" <darrick.wong@oracle.com> - 2016-03-29 00:50 +0200
      Re: Build regressions/improvements in v4.6-rc1 Mikael Starvik <mikael.starvik@axis.com> - 2016-03-29 08:20 +0200
      Re: Build regressions/improvements in v4.6-rc1 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-29 08:50 +0200

csiph-web