Re: [PATCH v2 09/10] tty: Consolidate noctty checks in tty_open()

From	Richard Weinberger <richard.weinberger@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 09/10] tty: Consolidate noctty checks in tty_open()
Date	2016-03-26 19:00 +0100
Message-ID	<rh0Fc-465-17@gated-at.bofh.it> (permalink)
References	<qzDqV-2GJ-3@gated-at.bofh.it> <qPgA1-87H-1@gated-at.bofh.it> <qPgA2-87H-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jan 10, 2016 at 6:13 AM, Peter Hurley <peter@hurleysoftware.com> wrote:
> Evaluate the conditions which prevent this tty being the controlling
> terminal in one place, just before setting the controlling terminal.
>
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
>  drivers/tty/tty_io.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)

Peter,

This commit breaks existing userspace.
I noticed that on UserModeLinux with Debian Squeeze as userspace, getty does not
give me a controlling tty upon login.
It does not seem to happen on newer distros. But still this needs
further investigation.

Please me know what debug information you need.

-- 
Thanks,
//richard

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 09/10] tty: Consolidate noctty checks in tty_open() Richard Weinberger <richard.weinberger@gmail.com> - 2016-03-26 19:00 +0100
  Re: [PATCH v2 09/10] tty: Consolidate noctty checks in tty_open() Peter Hurley <peter@hurleysoftware.com> - 2016-03-26 20:10 +0100
    Re: [PATCH v2 09/10] tty: Consolidate noctty checks in tty_open() Richard Weinberger <richard@nod.at> - 2016-03-26 20:20 +0100

csiph-web