Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1364549

Re: [PATCH v2] ARM: exynos_defconfig: Enable Samsung media platform drivers as modules

From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] ARM: exynos_defconfig: Enable Samsung media platform drivers as modules
Date 2016-03-25 04:20 +0100
Message-ID <rgqs1-3Vo-3@gated-at.bofh.it> (permalink)
References <rg1WF-3mB-3@gated-at.bofh.it> <rg1WF-3mB-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello Krzysztof,

On 03/23/2016 10:00 PM, Krzysztof Kozlowski wrote:
> On 24.03.2016 09:26, Javier Martinez Canillas wrote:
>> There are a bunch of media platform drivers under drivers/media/platform/
>> that are for Samsung SoCs but are not being built with exynos_defconfig.
>>
>> This patch enables them as a module to improve build coverage for these
>> drivers and also to allow people use them with proper hardware if modules
>> are installed. The S5P MFC driver wasn't enabled since it fails to probe.
>>
>> Only the boolean Kconfig symbols are enabled as built-in, since drivers
>> are not critical and also to keep the kernel binary image size as small
>> as possible.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>> Changes in v2:
>> - Remove S5P G2D and GSC symbols since overlaps with Exynos DRM functionality.
>>   Suggested by Tobias Jakobi
>>
>>  arch/arm/configs/exynos_defconfig | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
> 
> Looks good.
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>

Thanks for the review.
 
> 
> How about doing the same for multi_v7?
>

I didn't consider multi_v7 because media drivers aren't necessary for booting
the boards and so it could increase build times for not real benefits in most
machines. But I can enable it in multi_v7 as a follow-up if you think that it
makes sense there too.
 
> 
> Best regards,
> 
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2] ARM: exynos_defconfig: Enable Samsung media platform  drivers as modules Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-24 02:10 +0100
  Re: [PATCH v2] ARM: exynos_defconfig: Enable Samsung media platform  drivers as modules Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-25 04:20 +0100
    Re: [PATCH v2] ARM: exynos_defconfig: Enable Samsung media platform  drivers as modules Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-28 06:30 +0200
      Re: [PATCH v2] ARM: exynos_defconfig: Enable Samsung media platform  drivers as modules Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-28 07:20 +0200
        Re: [PATCH v2] ARM: exynos_defconfig: Enable Samsung media platform  drivers as modules Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-28 17:20 +0200
          Re: [PATCH v2] ARM: exynos_defconfig: Enable Samsung media platform  drivers as modules Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-29 03:30 +0200

csiph-web