Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1364388

[PATCH v4 2/5] drm/dp_helper: Always wait before retrying native aux transactions

Show all headers | View raw

This is part of a patch series to migrate all of the workarounds for
commonly seen behavior from bad sinks in intel_dp_dpcd_read_wake() to
drm's DP helper.

Some sinks need some time during the process of resuming the system from
sleep before they're ready to handle transactions. While it would be
nice if they responded with NACKs in these scenarios, this isn't always
the case as a few sinks will just timeout on all of the transactions
they receive until they're ready.

Signed-off-by: Lyude <cpaul@redhat.com>
---
 drivers/gpu/drm/drm_dp_helper.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index d1128fb..3b915e2 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -179,7 +179,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,
 {
 	struct drm_dp_aux_msg msg;
 	unsigned int retry;
-	int err;
+	int err = 0;
 
 	memset(&msg, 0, sizeof(msg));
 	msg.address = offset;
@@ -194,6 +194,10 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,
 	 * sufficient, bump to 32 which makes Dell 4k monitors happier.
 	 */
 	for (retry = 0; retry < 32; retry++) {
+		if (err != 0 && err != -ETIMEDOUT) {
+			usleep_range(AUX_RETRY_INTERVAL,
+				     AUX_RETRY_INTERVAL + 100);
+		}
 
 		mutex_lock(&aux->hw_mutex);
 		err = aux->transfer(aux, &msg);
@@ -205,7 +209,6 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,
 			return err;
 		}
 
-
 		switch (msg.reply & DP_AUX_NATIVE_REPLY_MASK) {
 		case DP_AUX_NATIVE_REPLY_ACK:
 			if (err < size)
@@ -214,10 +217,6 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,
 
 		case DP_AUX_NATIVE_REPLY_NACK:
 			return -EIO;
-
-		case DP_AUX_NATIVE_REPLY_DEFER:
-			usleep_range(AUX_RETRY_INTERVAL, AUX_RETRY_INTERVAL + 100);
-			break;
 		}
 	}
 
-- 
2.5.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] drm/dp_helper: add workarounds from intel_dp_dpcd_read_wake() Lyude <cpaul@redhat.com> - 2016-03-23 20:40 +0100
  [PATCH v4 2/5] drm/dp_helper: Always wait before retrying native aux transactions Lyude <cpaul@redhat.com> - 2016-03-24 19:30 +0100
  [PATCH v4 1/5] drm/dp_helper: Increase retry interval to 1000us Lyude <cpaul@redhat.com> - 2016-03-24 19:30 +0100
  [PATCH v4 3/5] drm/dp_helper: Retry aux transactions on all errors Lyude <cpaul@redhat.com> - 2016-03-24 19:30 +0100
  [PATCH v4 4/5] drm/dp_helper: Perform throw-away read before actual read in drm_dp_dpcd_read() Lyude <cpaul@redhat.com> - 2016-03-24 19:30 +0100
  [PATCH v4 5/5] drm/i915: Get rid of intel_dp_dpcd_read_wake() Lyude <cpaul@redhat.com> - 2016-03-24 19:30 +0100
  [PATCH v4 0/5] Move workarounds from intel_dp_dpcd_read_wake() into drm's DP helpers Lyude <cpaul@redhat.com> - 2016-03-24 19:30 +0100

csiph-web