Re: [PATCH v2 1/8] i2c-mux: add common core data for every mux instance

From	Peter Rosin <peda@lysator.liu.se>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/8] i2c-mux: add common core data for every mux instance
Date	2016-03-24 20:10 +0100
Message-ID	<rgiNR-7cM-27@gated-at.bofh.it> (permalink)
References	<qNCbE-4Sl-5@gated-at.bofh.it> <qNCbE-4Sl-9@gated-at.bofh.it> <rgadz-EQ-1@gated-at.bofh.it> <rgbjl-1Fk-41@gated-at.bofh.it> <rgeqT-3Ql-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Vladimir,

On 2016-03-24 15:24, Vladimir Zapolskiy wrote:
> On 24.03.2016 13:05, Peter Rosin wrote:
>> On 2016-03-24 10:50, Vladimir Zapolskiy wrote:
>>> On 05.01.2016 17:57, Peter Rosin wrote:
>>>> @@ -196,21 +195,21 @@ static int i2c_arbitrator_probe(struct platform_device *pdev)
>>>>  		dev_err(dev, "Cannot parse i2c-parent\n");
>>>>  		return -EINVAL;
>>>>  	}
>>>> -	arb->parent = of_get_i2c_adapter_by_node(parent_np);
>>>> +	muxc->parent = of_find_i2c_adapter_by_node(parent_np);
>>>
>>> why do you prefer here to use "unlocked" version of API?
>>>
>>> Foe example would it be safe/possible to unload an I2C bus device driver
>>> module or unbind I2C device itself in runtime?
>>
>> I think you ask why I change from of_get_i2c_... to of_find_i2c_..., and that
>> change was not intentional. It was the result of a bad merge during an early
>> rebase.
>>
>> Does that cover it?
>>
> 
> Yep, thank you for clarification, please account this in v3.

Oh , v3 is old news, v4 was sent out some weeks ago, and there is a v5
on a github branch. This bad rebase was fixed in v4.

> I'll try to find some time to review the whole changeset carefully,
> in fact I briefly reviewed it two months ago, but I didn't find
> anything obviously wrong that time.

Please put that on hold until I have rebased ontop of v4.6-rc1 and
changed a couple of other things. I'd hate for you to waste your
time on outdated patches.

Cheers,
Peter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/8] i2c-mux: add common core data for every mux  instance Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-03-24 11:00 +0100
  Re: [PATCH v2 1/8] i2c-mux: add common core data for every mux instance Peter Rosin <peda@lysator.liu.se> - 2016-03-24 12:10 +0100
    Re: [PATCH v2 1/8] i2c-mux: add common core data for every mux  instance Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-03-24 15:30 +0100
      Re: [PATCH v2 1/8] i2c-mux: add common core data for every mux instance Peter Rosin <peda@lysator.liu.se> - 2016-03-24 20:10 +0100

csiph-web