Re: [PATCH 1/1] net: macb: replace macb_writel() call by queue_writel() to update queue ISR

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] net: macb: replace macb_writel() call by queue_writel() to update queue ISR
Date	2016-03-24 20:00 +0100
Message-ID	<rgiE9-6S6-3@gated-at.bofh.it> (permalink)
References	<rgeAy-3Uf-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Date: Thu, 24 Mar 2016 15:40:04 +0100

> macb_interrupt() should not use macb_writel(bp, ISR, <value>) but only
> queue_writel(queue, ISR, <value>).
> 
> There is one IRQ and one set of {ISR, IER, IDR, IMR} [1] registers per
> queue on gem hardware, though only queue0 is actually used for now to
> receive frames: other queues can already be used to transmit frames.
> 
> The queue_readl() and queue_writel() helper macros are designed to access
> the relevant IRQ registers.
> 
> [1]
> ISR: Interrupt Status Register
> IER: Interrupt Enable Register
> IDR: Interrupt Disable Register
> IMR: Interrupt Mask Register
> 
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Fixes: bfbb92c44670 ("net: macb: Handle the RXUBR interrupt on all devices")

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] net: macb: replace macb_writel() call by queue_writel() to update queue ISR Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-03-24 15:40 +0100
  Re: [PATCH 1/1] net: macb: replace macb_writel() call by  queue_writel() to update queue ISR Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-03-24 16:40 +0100
  Re: [PATCH 1/1] net: macb: replace macb_writel() call by  queue_writel() to update queue ISR David Miller <davem@davemloft.net> - 2016-03-24 20:00 +0100

csiph-web